On Mon, Jun 29, 2015 at 2:37 AM, Erik de Bruin <e...@ixsoftware.nl> wrote:
> > > > Actually, I just studied the code more and it's subclass hell(I didn't > work > > on this part of the framework). > > > > > Thanks, mate ;-) > > That should teach you to always do everything yourself! > No, I realized after I sent it, what I said came out wrong. I understand how the 3 levels got there Erik. My sub class hell comment was the fact I thought I fixed something in GoogPublisher when I should have done my home work and seen publish() was completely overriden in what JSC type was actually using. This exact scenario is why I favored composition over subclassing. And yeah I started the mess. Again I am sorry for saying that, I didn't mean it that "you" were the one that created it, just it probably needs to be refactored. Mike > > EdB > > P.S. In case you missed it, I'm just kidding. There are (many) parts of the > code that deserve the attention of someone with more experience to review > and suggest changes. It was all I could do to keep the tests passing and > get the new functionality working, now it's someone else's job to clean up > the mess I made. > > > > -- > Ix Multimedia Software > > Jan Luykenstraat 27 > 3521 VB Utrecht > > T. 06-51952295 > I. www.ixsoftware.nl >
