Thanks for sticking with it. I have my fingers crossed. -Alex
On 12/8/15, 7:58 AM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: >Just pushed another commit. Locally all the mustella tests in the >spark/Collections/Sort/Other are now passing, fingers crossed that all >the other sort-related ones will also pass. >The lesson: moving from inheritance to composition can be super >complicated! Events, the new class member using "this" instead of the >parent, framework classes calling functions via object["initialized"] >instead of an interface, etc. Still worth it, though, to remove code >duplication (in this case the mx versions of Sort and SortField were >mostly - and imperfectly - copy-pasted in their spark counterparts. >This meant that a change to one had to be reflected in the other, >which usually didn't happen. It also meant that tests would have >needed duplication as well, etc). > >On 3 December 2015 at 15:51, Mihai Chira <mihai.ch...@gmail.com> wrote: >> In the end it's an improvement, but in the end 5 test cases are still >> failing. Right now I'm travelling, and won't be able to take another >> look until Saturday. Does someone else want to help out? >> >> On 3 December 2015 at 15:18, Alex Harui <aha...@adobe.com> wrote: >>> Excellent! Thanks, -Alex >>> >>> On 12/3/15, 6:01 AM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: >>> >>>>About to commit and push a fix for this in the next hour. (It took me >>>>so long because my HDD had bad sectors which caused lots of pain in >>>>the last few days.) >>>> >>>>On 24 November 2015 at 18:03, Alex Harui <aha...@adobe.com> wrote: >>>>> >>>>> >>>>> On 11/24/15, 8:41 AM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: >>>>> >>>>>>Yes, but the earliest I can do that is on Monday. I hope that still >>>>>>works >>>>>>regarding the release. (And I hope I'll manage to solve it, but we'll >>>>>>see.) >>>>>>On 24 Nov 2015 08:19, "Alex Harui" <aha...@adobe.com> wrote: >>>>> >>>>> I don't know of any plans to cut an RC this week, so I think Monday >>>>>should >>>>> be ok. >>>>> >>>>> Thanks, >>>>> Alex >>>>> >>>
