Hi, -1 binding due to crypto code included in binary. If that resolved I would be +0 as I still can’t compile from the source package. If that was resolved I’d vote +1.
I checked the following: - Signatures and hashes good - Source NOTICE+ LICENSE is OK - Binary NOTICE is OK - Binary LICENSE has some minor issues - Docs LICENSE + NOTICE is OK - All source files have Apache headers - Still unable to compile from source Binary LICENSE has some minor issues: - Could have Apache licensed Google Caja project [1][2][3] While not required by current policy it seem odd to mention one 3rd party Apache licence software in LICENSE but not another. - Contains code from Apache Shindig [4], this has a NOTICE file [5] which would liekly effect our binary NOTICE file. - This file [6] is based on BSD license code [7] - This file [8] contains code from http://www.json.org/json2.js which is public domain. - This file [9]contains code from http://webfx.eae.net/dhtml/slider/js/range.js which is Apache licensed. - The BSD licensed file [10] contains code from http://www.bytestrom.eu/blog/2009/1120a_jpeg_encoder_for_javascript (unknown license). These can be fixed in the next release. There probably a few other things bundled in there as well as I’ve not looked at everything. The bigger issue is that is looks like there is crypto code bundled here [11]. I’m not 100% sure if it required but have we followed the policy here [12] and informed the US government? Thanks, Justin 1. ./js/lib/google/closure-library/third_party/closure/goog/caja/string/html/htmlparser.js 2. ./js/lib/google/closure-library/third_party/closure/goog/caja/string/html/htmlsanitizer.js 3. https://github.com/google/caja/blob/master/LICENSE.txt 4. ./js/lib/google/closure-library/third_party/closure/goog/osapi/osapi.js 5. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 6. ./js/lib/google/closure-library/third_party/closure/goog/loremipsum/text/loremipsum.js 7. https://code.google.com/archive/p/lorem-ipsum-generator/ 8. ./js/lib/google/closure-library/closure/goog/json/json.js 9 ./js/lib/google/closure-library/closure/goog/ui/rangemodel.js 10. ./js/lib/google/closure-library/third_party/closure/goog/jpeg_encoder/jpeg_encoder_basic.js 11. ./js/lib/google/closure-library/closure/goog/crypt 12. http://www.apache.org/dev/crypto.html
