Hi Alex,
I posted the link to my SonarQube several times ... currently there are 193 blocker issues ... I think I fixed quite some today, but still there's a lot to check. http://dev.c-ware.de:10000/component_issues?id=org.apache.flex.flexjs%3Aflexjs-parent#resolved=false|facetMode=debt|severities=BLOCKER The Number of Blocker + Critical Issues currently is around 2000 ... as I said we should start working on reducing technical debt. At least on the Java side we produce technical debt faster than code :-( I think it would be good to check the quality of code produced by the authors themselves. The educational benefit is enormous [?] Chris ________________________________ Von: Alex Harui <[email protected]> Gesendet: Freitag, 17. Juni 2016 16:02:26 An: [email protected] Betreff: Re: AW: AW: Coding conventions? On 6/17/16, 1:37 AM, "Christofer Dutz" <[email protected]> wrote: >And we definitely should look at the blocker issues ... I am for example >using some little breaks to handle a few of them ... > > >Stuff like this shouldn't be in anything else than a POC: > > >if (newLoc != null) > b.addLocation(newLoc); >else newLoc.getFile(); // force NullPointerException if newLoc == null Well, you are certainly welcome to tackle these things. I guess the question is whether we should put off Maven for another release and get a 0.7.0 out the door. What do other's think? The code snippet above was inherited from Adobe and also exists in the Flex SDK's version of FDB, so we've lived with it a long time already. What other blocker issues are there? I'd rather make sure the example apps run when everything is built in Maven and cut a release. Maybe that will attract more volunteers who can help us clean up this stuff. -Alex
