Hi Alex,

Thanks for the updated file. After looking over the contents I was
surprised how many classes are involved and how easy it is to get
lost in all that. In order to get a better overview of all this I would 
suggest to put all the different JSON files into a single
XML file that can then be traversed via e4x much more easily. 

Something like this:

<classes>
        <class name="org.apache.flex.core.UIButtonBase" 
base="UIHTMLElementWrapper" desc="The UIHTMLElementWrapper class is the base 
class for most Buttons and other UI objects in a FlexJS application that do not 
have children.">
                <constructor params=""/>
                <prop qname="x" access="read-write" ns="public" override="true" 
return="value" desc=""/>
                <prop qname="y" access="read-write" ns="public" override="true" 
return="value" desc=""/>
                <prop qname="height" access="read-write" ns="public" 
return="Number" bindable="heightChanged" override="true" desc=""/>
                <prop qname="$height" access="read-only" ns="public" 
return="Number" desc="Retrieve the low-level bounding box height. Not 
implemented in JS."/>
                <method qname="createElement" ns="protected" params="" 
return="IFlexJSElement" desc=""/>
        </class>
        <class name=“…. next class …/>
        <class name=“…. next class …/>
        <class name=“…. next class …/>
</classes>

This XML could be used as a dataProvider for a help page, would
be easier to read out info for snippets, and it would also be easier
for anybody reading just the XML file (instead of tons of JSON files).

What do you think?

- Christian



> On Dec 6, 2016, at 2:01 AM, Alex Harui <aha...@adobe.com> wrote:
> 
> Thanks for looking.  I think I've fixed these issues and updated the zip.
> There's probably more, so maybe after I get caught up on compiler bugs
> I'll write the basis of the AIR app that will display ASDoc which will
> then read all of these files and find more problems.
> 
> -Alex
> 
> On 12/5/16, 2:11 PM, "Harbs" <harbs.li...@gmail.com> wrote:
> 
>> One last one:
>> ToolTipBead.json has TWO trailing commas near the end of the file.
>> 
>> On Dec 6, 2016, at 12:10 AM, Harbs <harbs.li...@gmail.com> wrote:
>> 
>>> Some more:
>>> 
>>> CurrencyFormatter.json has the following:
>>> 
>>>         "params": [{ name: "value", type: "Object"}
>>> 
>>> name and type need to be surrounded by quotes.
>>> 
>>> I’m done for the night… ;-)
>>> 
>>> On Dec 6, 2016, at 12:07 AM, Harbs <harbs.li...@gmail.com> wrote:
>>> 
>>>> Accordion.json looks like it has two errors as well:
>>>> 1. The leading comma here:
>>>> "members": [
>>>> ,
>>>> 2. The trailing comma here:
>>>> "namespace": "public”,
>>>> 
>>>> On Dec 6, 2016, at 12:04 AM, Harbs <harbs.li...@gmail.com> wrote:
>>>> 
>>>>> That looks good.
>>>>> 
>>>>> I randomly opened some other files and ComboBox has the following
>>>>> error:
>>>>> 
>>>>> parse error: invalid object key (must be a string)
>>>>>       he.flex.events.Event",       }]   }
>>>>>                  (right here) ------^
>>>>> 
>>>>> The problem looks like a trailing comma near the end of the file.
>>>>> (after Event)
>>>>> 
>>>>> On Dec 5, 2016, at 11:57 PM, Alex Harui <aha...@adobe.com> wrote:
>>>>> 
>>>>>> Thanks for checking.  I think I have it as valid JSON now and
>>>>>> updated the
>>>>>> zip.
>>>>>> 
>>>>>> -Alex
>>>>>> 
>>>>>> On 12/5/16, 12:19 PM, "Harbs" <harbs.li...@gmail.com> wrote:
>>>>>> 
>>>>>>> It looks like there’s an error in the JSON. I opened CheckBox.json
>>>>>>> and I
>>>>>>> got the following error:
>>>>>>> 
>>>>>>> parse error: after key and value, inside map, I expect ',' or '}'
>>>>>>>          "values": ["3.0"]}  ]  "return": "",           "params"
>>>>>>>                (right here) ———^
>>>>>>> 
>>>>>>> It looks like there’s a comma missing.
>>>>>>> 
>>>>>>> On Dec 5, 2016, at 9:38 PM, Alex Harui <aha...@adobe.com> wrote:
>>>>>>> 
>>>>>>>> I just pushed a new set of json files.  The accessors should now
>>>>>>>> have
>>>>>>>> "return" fields.
>>>>>>>> Looks like default values are supposed to come from @default tags
>>>>>>>> in the
>>>>>>>> ASDoc, which we haven't written yet. I added one to CheckBox just
>>>>>>>> to see
>>>>>>>> if it would work and it does appear in the output.  We would need
>>>>>>>> some
>>>>>>>> volunteers to help populate the ASDoc with @default tags.
>>>>>>>> 
>>>>>>>> Let me know if there are other things missing.
>>>>>>>> 
>>>>>>>> [1] http://home.apache.org/~aharui/FlexJS/asdoc-output.zip
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Thanks,
>>>>>>>> -Alex
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
>> 
> 

Reply via email to