I got rid of circulars which was causing the two SubParagraphGroupElementBase errors, but the StandardFlowComposer error seems wrong to me. (Of course I could be missing something…)
> On Mar 13, 2017, at 10:28 PM, Harbs <harbs.li...@gmail.com> wrote: > > I’m getting these three errors with remove-circulars enabled. > > [java] Mar 13, 2017 10:17:00 PM > com.google.javascript.jscomp.LoggerErrorManager println > [java] SEVERE: > /Users/harbs/Documents/git/PrintUI/printui-flexjs/text_engine/test/HelloWorldTLF/bin/js-debug/org/apache/flex/textLayout/compose/FactoryComposer.js:12: > ERROR - required "org.apache.flex.textLayout.compose.StandardFlowComposer" > namespace not provided yet > [java] > goog.require('org.apache.flex.textLayout.compose.StandardFlowComposer'); > [java] > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > [java] > [java] Mar 13, 2017 10:17:00 PM > com.google.javascript.jscomp.LoggerErrorManager println > [java] SEVERE: > /Users/harbs/Documents/git/PrintUI/printui-flexjs/text_engine/test/HelloWorldTLF/bin/js-debug/org/apache/flex/textLayout/elements/LinkElement.js:14: > ERROR - required > "org.apache.flex.textLayout.elements.SubParagraphGroupElementBase" namespace > not provided yet > [java] > goog.require('org.apache.flex.textLayout.elements.SubParagraphGroupElementBase'); > [java] > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > [java] > [java] Mar 13, 2017 10:17:00 PM > com.google.javascript.jscomp.LoggerErrorManager println > [java] SEVERE: > /Users/harbs/Documents/git/PrintUI/printui-flexjs/text_engine/test/HelloWorldTLF/bin/js-debug/org/apache/flex/textLayout/elements/TCYElement.js:12: > ERROR - required > "org.apache.flex.textLayout.elements.SubParagraphGroupElementBase" namespace > not provided yet > [java] > goog.require('org.apache.flex.textLayout.elements.SubParagraphGroupElementBase'); > [java] > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > These three classes are all classes which subclass the not-provided class. > >> On Mar 13, 2017, at 10:18 PM, Harbs <harbs.li...@gmail.com> wrote: >> >> I pulle the latest commit and the error went away. >> >> I’m looking to see if the output is better. >> >>> On Mar 13, 2017, at 9:57 PM, Harbs <harbs.li...@gmail.com> wrote: >>> >>> I just tried and got this error: >>> >>> [java] Compiling file: >>> /Users/harbs/Documents/git/PrintUI/printui-flexjs/text_engine/test/HelloWorldTLF/bin/js-debug/HelloWorldTLF.js >>> [java] HelloWorldTLF as: [HelloWorldTLF, >>> org.apache.flex.textLayout.container.ContainerController, NaN, >>> org.apache.flex.textLayout.elements.Configuration, >>> org.apache.flex.textLayout.elements.TextFlow, >>> org.apache.flex.textLayout.factory.StandardTLFFactory, >>> org.apache.flex.textLayout.elements.ParagraphElement, >>> org.apache.flex.textLayout.elements.SpanElement, >>> org.apache.flex.text.engine.TextEngine, >>> org.apache.flex.text.svg.SVGTextFactory] >>> [java] HelloWorldTLF mxml: [org.apache.flex.core.View, >>> org.apache.flex.html.Label, org.apache.flex.svg.GraphicContainer, >>> org.apache.flex.core.SimpleCSSValuesImpl, HelloWorldTLF, >>> org.apache.flex.core.Application, org.apache.flex.events.Event] >>> [java] 1.926593088 seconds >>> [java] >>> java.lang.String.contains(String.java:2133)org.apache.flex.compiler.internal.codegen.mxml.flexjs.MXMLFlexJSPublisher.closureFilesInOrder(MXMLFlexJSPublisher.java:455)org.apache.flex.compiler.internal.codegen.mxml.flexjs.MXMLFlexJSPublisher.publish(MXMLFlexJSPublisher.java:240)org.apache.flex.compiler.clients.MXMLJSC.compile(MXMLJSC.java:455)org.apache.flex.compiler.clients.MXMLJSC._mainNoExit(MXMLJSC.java:313)org.apache.flex.compiler.clients.MXMLJSC.mainNoExit(MXMLJSC.java:270)org.apache.flex.compiler.clients.MXMLJSC.staticMainNoExit(MXMLJSC.java:232)org.apache.flex.compiler.clients.MXMLJSC.main(MXMLJSC.java:176) >>> [java] >>> [java] >>> >>> >>> >>>> On Mar 13, 2017, at 7:33 PM, Alex Harui <aha...@adobe.com> wrote: >>>> >>>> So I just pushed some changes in flex-falcon that might help. Give it a >>>> try and let me know... >>>> >>>> -Alex >>>> >>>> On 3/10/17, 10:45 PM, "Alex Harui" <aha...@adobe.com> wrote: >>>> >>>>> Ah crud. Nevermind. I didn't have remove-circulars in the failing case. >>>>> >>>>> Still pondering... >>>>> -Alex >>>>> >>>>> On 3/10/17, 4:17 PM, "Alex Harui" <aha...@adobe.com> wrote: >>>>> >>>>>> For those keeping track, I think I have gathered enough evidence to >>>>>> conclude that it is a Java 6 vs 7 difference in the Hash iterators that >>>>>> is >>>>>> fooling the way we build the list of files for GCC. >>>>>> >>>>>> I will look into fixing that. >>>>>> >>>>>> -Alex >>>>>> >>>>>> On 3/10/17, 11:27 AM, "Alex Harui" <aha...@adobe.com> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On 3/9/17, 2:35 PM, "Harbs" <harbs.li...@gmail.com> wrote: >>>>>>> >>>>>>>> It looks to me like the missing definitions are classes which are only >>>>>>>> used in static methods. >>>>>>>> >>>>>>>> Could it be that Falcon is not properly declaring dependencies in >>>>>>>> static >>>>>>>> methods? >>>>>>> >>>>>>> I think the issue is the order of files being passed to GCC. I am >>>>>>> investigating. >>>>>>> >>>>>>> -Alex >>>>>>> >>>>>> >>>>> >>>> >>> >> >