I never said it wasn't important/serious. I did not say it is an optimization issue.
The changes you made look fine. Seems like eventually we'll have to initialize other types as well. It makes every variable be like every airline passenger going through the metal detector. Safe, but inefficient at times. There are other options out there that are less safe and more efficient in certain scenarios. That's how optimization often works. It detects certain patterns and optimizes for them. Me, I'd happily change the way I write code in order to leverage these optimizations. Some folks will agree, some won't, doesn't matter, there'll be options to control the output. -Alex On 6/10/17, 8:12 PM, "Justin Mclean" <jus...@classsoftware.com> wrote: >Hi, > >So to summarise this thread. >- discussing if Boolean be initialised to false and Numbers to NaN >- Code can act differently on AS and JS when these initialisers are not >present >- Josh and I think this a serious bug >- Harbs also sees the issue >- Piotrz also wants Booleans and Numbers to be initialised >- Alex thinks this is an optimisation issue > >I’ve went ahead and made the change and checked into a new initialization >branch of falcon. > >Testing with a real world application gave no notable size increase and >improved performance by 10% on JS. Mostly I would guess due to use of == >and != in the framework and implicit casting that goes on when when >comparing uninitialised variables. > >Thanks, >Justin
