Hi Justin, You cut my previous reply which means I need to repeat.
You called out changes since 0.8. And I only looked at the change since in Sonar. I took about 5 minutes, a very superficial check. Lots of TD should be explored carefully hopefully by the original developer. I agree with the notion that these changes should be at the beginning of a cycle. My point in general was the the recent changes do look pretty clean. Let's see what the developers think. Regards, Dave Sent from my iPhone > On Jul 5, 2017, at 6:19 PM, Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > >> In the differential all 30 of the bugs are of the form: >> >> Make this class “<whatever>Event" override "Event.clone()” function > > Which some are false positives as there’s a cloneEvent method. Note you can > mark them as such in the interface. I had already fixed a couple of these a > few weeks back. > >> The singular code smell (Sonar says that flex smells very good indeed.) > > Not sure where you seeing just 1 as I can see 13,100 and their are a > varieties of issues. Again some worth looking into and others not. > > Thanks, > Justin
