One of them was documentation edits. Another was a workaround for a Flash permissions issue. It was a sometime yes, sometimes no problem. I finally found where the problem lay that required that code. You can see the comments in old issues on that repo. That piece of code is very necessary for Flash. There’s really only one way to solve that particular issue. Not sure if he can own that solution.
The third was some convenience methods. Not a major contribution. > On Jul 14, 2017, at 12:07 AM, Alex Harui <aha...@adobe.com.INVALID> wrote: > > Made two comments in the GH issue. Looks like there were other > contributors so we may need to get their permission to make the license > ALv2. > > Of course, I could be wrong,... > -Alex > > On 7/12/17, 9:14 PM, "Harbs" <harbs.li...@gmail.com> wrote: > >> I don’t think he has plans on modifying it. >> >> Do you mind making the suggestion about the header to the Github issue? >> >>> On Jul 13, 2017, at 7:10 AM, Alex Harui <aha...@adobe.com.INVALID> >>> wrote: >>> >>> IMO, if the original author will be helping make changes to this file, >>> we >>> want an ICLA. If he has no plans to work on it, then attaching it to a >>> JIRA would be sufficient documentation of his intent to donate it. >>> >>> Either way, it would help if he put the 3rd-party ALv2 header in the >>> file. >>> >>> -Alex >>> >>> On 7/12/17, 8:59 PM, "Harbs" <harbs.li...@gmail.com> wrote: >>> >>>> In our repo with my modifications for FlexJS. >>>> >>>> >>>>> On Jul 13, 2017, at 1:22 AM, Alex Harui <aha...@adobe.com.INVALID> >>>>> wrote: >>>>> >>>>> What do you mean by "adopt". That the new home for further >>>>> improvements >>>>> is in our repo or that we're using it as a third-party dependency? >>>>> >>>>> -Alex >>>>> >>>>> On 7/12/17, 12:45 PM, "Harbs" <harbs.li...@gmail.com> wrote: >>>>> >>>>>> There’s a great class for uploading multi-part HTTP requests. I’ve >>>>>> been >>>>>> using it for years, and I’ve ported it for use with FlexJS. It works >>>>>> great in that context too. >>>>>> >>>>>> I just asked the author if he minds if we adopt it and he’s very >>>>>> happy >>>>>> for us to do so.[1] >>>>>> >>>>>> It’s one class. Do we need to go through an ICLA, or can we just >>>>>> bring >>>>>> it >>>>>> in with no fuss? >>>>>> >>>>>> Thanks, >>>>>> Harbs >>>>>> >>>>>> >>>>>> >>>>>> [1]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi >>>>>> th >>>>>> ub >>>>>> >>>>>> >>>>>> .com%2Fjimojon%2FMultipart.as%2Fissues%2F9&data=02%7C01%7C%7C61a62bf56 >>>>>> 17 >>>>>> 14 >>>>>> >>>>>> >>>>>> 5e9929708d4c95e9650%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63635 >>>>>> 48 >>>>>> 55 >>>>>> >>>>>> >>>>>> 465043104&sdata=2SKnAIfWKXwDacqORK3Td9AyYffkEXBYr%2BTPdtm6efo%3D&reser >>>>>> ve >>>>>> d= >>>>>> 0 >>>>>> >>>>>> >>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >>>>>> ub >>>>>> .c >>>>>> >>>>>> >>>>>> om%2Fjimojon%2FMultipart.as%2Fissues%2F9&data=02%7C01%7C%7C61a62bf5617 >>>>>> 14 >>>>>> 5e >>>>>> >>>>>> >>>>>> 9929708d4c95e9650%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363548 >>>>>> 55 >>>>>> 46 >>>>>> >>>>>> >>>>>> 5043104&sdata=2SKnAIfWKXwDacqORK3Td9AyYffkEXBYr%2BTPdtm6efo%3D&reserve >>>>>> d= >>>>>> 0> >>>>> >>>> >>> >> >
