We don't do any rewriting right now, but we might be able to rewrite them
in the future.
One warning I see is from this code:
/**
* @export
* @type {org.apache.flex.core.WrappedHTMLElement} */
positioner: {
get: org.apache.flex.core.UIBase.prototype.get__positioner,
set: org.apache.flex.core.UIBase.prototype.set__positioner},
I think this is needed so that
positioner.flexjs_wrapper
gets properly handled during minification. However, WrappedHTMLElement
doesn't really get used at runtime. The positioner is really only going
be an HTMLElement that we add a flexjs_wrapper property to. We only use
WrappedHTMLElement to satisfy the compilers. I'd rather not include the
JS for WrappedHTMLElement just to satisfy GCC. We could scan through the
output JS and find all references to flexjs_wrapper and rewrite them to be
["fw"] or something like that and then replace the @type with HTMLElement.
Or maybe there's a better idea on how to handle this. I'm leaning towards
just suppressing the warning.
Thoughts?
-Alex
On 8/22/17, 7:43 AM, "piotrz" <[email protected]> wrote:
>Alex,
>
>What do you mean by rewriting those getter/setters ? Could you point to an
>some example ?
>
>Thanks,
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[email protected]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-Closure-warnings-tp63939p6394
>4.html&data=02%7C01%7C%7C64a23899f1a54bb416d708d4e96c95a1%7Cfa7b1b5a7b3443
>8794aed2c178decee1%7C0%7C0%7C636390099994613429&sdata=DcPm4bhO2S%2F9gjFtYW
>6iiOdpOZmu7nmiBrPEaT1nYso%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
