Hi all vote pass with three +1 binding votes. No -1 or 0 votes. We now have a release 1.0.0 for the flex mavenizer! So closing this vote thread. Congratulations for this achievement! :)
El dom., 17 nov. 2019 a las 15:25, Carlos Rovira (<carlosrov...@apache.org>) escribió: > Hi Chris, > > just tested you changes and all worked flawlessly. > I committed the improvements to Apache Royale right now too. > Many thanks > > > El dom., 17 nov. 2019 a las 14:40, Christofer Dutz (<cd...@apache.org>) > escribió: > >> +1 (binding) >> >> Chris >> >> - Hashes are correct >> - Signatures OK and are linked to an Apache Email Address >> - Checked the LICENSE, NOTICE, README and RELEASE_NOTES >> - External RAT check reports all is OK header-wise >> - Compiling with test passes >> >> - Using the new extension in the Royale build works >> >> Steps for using the extension in the Royale build: >> - Add the staging repo to the settings-template.xml >> - Update the version of the extension in ".mvn/extensions.xml" from >> 1.0.0-SNAPSHOT to 1.0.0 >> - Delete the com/adobe directory in the maven local repo >> - Re-run the build with "option-with-swf" >> >> Here the updated settings-template.xml >> >> <?xml version="1.0" encoding="UTF-8"?> >> <!-- >> >> Licensed to the Apache Software Foundation (ASF) under one or more >> contributor license agreements. See the NOTICE file distributed with >> this work for additional information regarding copyright ownership. >> The ASF licenses this file to You under the Apache License, Version 2.0 >> (the "License"); you may not use this file except in compliance with >> the License. You may obtain a copy of the License at >> >> http://www.apache.org/licenses/LICENSE-2.0 >> >> Unless required by applicable law or agreed to in writing, software >> distributed under the License is distributed on an "AS IS" BASIS, >> WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. >> See the License for the specific language governing permissions and >> limitations under the License. >> >> --> >> <settings xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.1.0 >> http://maven.apache.org/xsd/settings-1.1.0.xsd"; >> xmlns="http://maven.apache.org/SETTINGS/1.1.0"; >> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> >> >> <!-- Tell maven to place downloaded files relative to this settings >> file --> >> <!--localRepository>.mvn/repository</localRepository--> >> >> <!-- If you need to use a proxy, comment in this section --> >> <!--proxies> >> <proxy> >> <active>true</active> >> <protocol>proxy-protocol (http/https)</protocol> >> <host>proxy-host</host> >> <port>proxy-port</port> >> </proxy> >> </proxies--> >> >> <!-- Profile that adds the apache snapshot repo to maven --> >> <profiles> >> <profile> >> <id>apache-snapshots-enabled</id> >> <!--Enable snapshots for the built in central repo and plugin >> repo --> >> <repositories> >> <repository> >> <id>apache-snapshots</id> >> <url>https://repository.apache.org/snapshots/</url> >> <releases> >> <enabled>false</enabled> >> </releases> >> <snapshots> >> <enabled>true</enabled> >> </snapshots> >> </repository> >> <repository> >> <id>apache-mavenizer-staging</id> >> <url> >> https://repository.apache.org/content/repositories/orgapacheflex-1022 >> </url> >> <releases> >> <enabled>true</enabled> >> </releases> >> <snapshots> >> <enabled>false</enabled> >> </snapshots> >> </repository> >> </repositories> >> <pluginRepositories> >> <pluginRepository> >> <id>apache-snapshots</id> >> <url>https://repository.apache.org/snapshots/</url> >> <releases> >> <enabled>false</enabled> >> </releases> >> <snapshots> >> <enabled>true</enabled> >> </snapshots> >> </pluginRepository> >> <pluginRepository> >> <id>apache-mavenizer-staging</id> >> <url> >> https://repository.apache.org/content/repositories/orgapacheflex-1022 >> </url> >> <releases> >> <enabled>true</enabled> >> </releases> >> <snapshots> >> <enabled>false</enabled> >> </snapshots> >> </pluginRepository> >> </pluginRepositories> >> </profile> >> </profiles> >> >> <!-- Activate the apache-snapshots-enabled profile --> >> <activeProfiles> >> <activeProfile>apache-snapshots-enabled</activeProfile> >> </activeProfiles> >> </settings> >> >> >> On 2019/11/17 11:49:56, Carlos Rovira <carlosrov...@apache.org> wrote: >> > +1 (binding) >> > >> > Thanks Justin, will do next time. I'm trying to learn as I'm new to this >> > process. >> > About checking it, as I stated before, I think the best way to do it is >> to >> > build Apache Royale with Maven. Here's the steps to do it: >> > >> > #!/bin/bash >> > >> > *export* >> FLASHPLAYER_DEBUGGER="/Users/christofer.dutz/Devtools/Adobe/Flash/FlashPlayer-32.0/Flash >> > Player.app/Contents/MacOS/Flash Player Debugger" >> > >> > *cd* royale-compiler >> > >> > ./mvnw install -s settings-template.xml >> > >> > *cd* ../royale-typedefs >> > >> > ./mvnw install -s settings-template.xml >> > >> > *cd* ../royale-asjs >> > >> > ./mvnw install -s settings-template.xml -P >> > with-examples,with-distribution,with-ui-testsuite,option-with-swf >> > -Dwebdriver.gecko.driver=/Users/christofer.dutz/Downloads/gecko-driver >> > >> > when we get this piece of code released, will be able to avoid -s >> > settings-template.xml from this recipe making it more easy to build. >> > >> > Thanks >> > >> > >> > >> > El sáb., 16 nov. 2019 a las 22:45, Justin Mclean (< >> jus...@classsoftware.com>) >> > escribió: >> > >> > > Hi, >> > > >> > > +1 (binding) >> > > >> > > Generally to want to cancel the editing vote and create a new thread >> when >> > > voting on a new RC, otherwise is may not be clear what people are >> voting on. >> > > >> > > I checked RC2: >> > > - Signatures and hashes fine >> > > - LICENSE and NOTICE fine >> > > - No unexpected binary files >> > > - All source files have ASF headers >> > > - Can compile from source (ion OSX using Java 1.8 and Apache Maven >> 3.3.9) >> > > >> > > I didn’t check if this works, after compiling what the easiest way to >> do >> > > that? >> > > >> > > Thanks, >> > > Justin >> > >> > >> > >> > -- >> > Carlos Rovira >> > http://about.me/carlosrovira >> > >> > > > -- > Carlos Rovira > http://about.me/carlosrovira > > -- Carlos Rovira http://about.me/carlosrovira
