Hi Flink community,

while reviewing the LICENSE and NOTICE file of Apache Flink, I noticed that
according to the LICENSE file Flink contains many java script files.
However, tracking the corresponding files back was not so easy, because
they are actually all merged into
flink-runtime-web/web-dashboard/web/js/vendor.js. Vendor.js is a large java
script file which is part of the result of the bower build process.

I was wondering why we added a "binary" file which is auto-generated to our
code base. Was/Is there any specific reason for it?

The problem is that the java script files contained in the vendor.js are
not exactly the set of declared bower dependencies in
flink-runtime-web/web-dashboard/bower.json. I suspect that also transitive
dependencies will be included. At least that is my only explanation why
we're referencing lodash.js, for example, in our LICENSE file (you can find
it deeply hidden in the vendor.js file).

Wouldn't it be easier to auto-generate the web-dashboard related files
while building Flink? This would not only clean up our repository but also
make the traceability of contained 3rd party code in our code base much
easier. Maybe this maven plugin [1] could help us.

[1] https://github.com/eirslett/frontend-maven-plugin

Cheers,
Till

Reply via email to