Hi Fabian, Thanks for your review.
- It would be good to make the number of concurrent AsyncFunction calls configurable. Maybe overload the unorderedWait and orderedWait methods with an additional int parameter? *That is right, the concurrent number is confiurable. I have updated the FLIP to provide extra methods to do so.* - Do you plan to also add a RichFunction variant of AsyncFunction? *Good point. Providing a rich function version could provide more control in asyncInvoke().* - Does it make sense to add a timeout thread for async calls to be able to cancel a request? *I think it is Async Client's reponsibility to handle timeout issue, but not FLINK. In AsyncFunction, user can configure connection timeout while setting up the function. AsyncWaitOperator provides a way to propogate timeout errors from async operation.* Thanks, David 2016-09-20 5:06 GMT+08:00 Fabian Hueske <fhue...@gmail.com>: > Hi David, > > thanks for the FLIP! It looks pretty good. A few questions / suggestions: > > - It would be good to make the number of concurrent AsyncFunction calls > configurable. Maybe overload the unorderedWait and orderedWait methods with > an additional int parameter? > - Do you plan to also add a RichFunction variant of AsyncFunction? > - Does it make sense to add a timeout thread for async calls to be able to > cancel a request? > > Best, Fabian > > > 2016-09-18 12:22 GMT+02:00 David Wang <dwan...@gmail.com>: > > > Hi Henry, > > > > Here is the FLIP: > > https://cwiki.apache.org/confluence/pages/viewpage. > action?pageId=65870673 > > > > Thanks, > > David > > > > 2016-09-15 12:26 GMT+08:00 Henry Saputra <henry.sapu...@gmail.com>: > > > > > HI David, > > > > > > Thanks so much for the interest to contribute to Apache Flink. > > > > > > To help review and DISCUSS for new feature in Flink, please do submit > > FLIP > > > [1] proposal. > > > > > > It will help the PMCs managing the new feature proposals and keep > > resources > > > with ASF realm. > > > > > > > > > Thanks, > > > > > > Henry > > > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/ > > > Flink+Improvement+Proposals > > > > > > On Sun, Sep 11, 2016 at 7:56 PM, Jeffery David <dwan...@gmail.com> > > wrote: > > > > > > > Hi ALL, > > > > > > > > Recently, we have designed and implemented a new proposal in FLINK to > > > > support Asynchronous Operation while streaming. The main feature of > > this > > > > proposal is to introduce async i/o operation in FLINK to boost the > TPS > > of > > > > streaming job without delaying the checkpoint, and provide an easy > way > > > for > > > > the FLINK users to implement their async i/o codes in FLINK job. > > > > > > > > Here is the link to Google Doc: > > > > https://docs.google.com/document/d/1Lr9UYXEz6s6R_ > > > > 3PWg3bZQLF3upGaNEkc0rQCFSzaYDI/edit > > > > > > > > Any feedback is appreciated. > > > > > > > > Thanks, > > > > David > > > > > > > > > >
