Thanks for addressing my comments. I really like the new web site!

If there are no objections, I would like to merge this later today.


On Tue, Jan 10, 2017 at 11:56 AM, Mike Winters <mwi...@gmail.com> wrote:
> Thanks for the comments, Ufuk.
>
> -I rearranged the front page so that the blog posts come before 'Powered
> By' logos--I think this makes sense.
> -Nav bar highlights issue is fixed
>
> Just pushed these changes, and the preview site (
> https://wints.github.io/flink-web/) has been updated as well.
>
> Best,
> Mike
>
> On Mon, Jan 9, 2017 at 6:12 PM, Ufuk Celebi <u...@apache.org> wrote:
>
>> Looks great!
>>
>> Some minor comments:
>>
>> - Font page: Maybe put the latest blog posts before the power by logos?
>> - Nav bar on the left: I noticed that for some links the active color
>> does not show. Clicking on "Blog" makes highlights the link but not
>> for others like "Powered By"
>>
>> On Mon, Jan 9, 2017 at 5:08 PM, Mike Winters <mwi...@gmail.com> wrote:
>> > Hi, you can also now preview the site here:
>> > https://wints.github.io/flink-web/.
>> >
>> > -Mike
>> >
>> > On Mon, Jan 9, 2017 at 3:07 PM, Mike Winters <mwi...@gmail.com> wrote:
>> >
>> >> Hi everyone,
>> >>
>> >> For the sake of having many sets of eyes to help catch potential
>> issues, I
>> >> decided to wait until after the new year to create a PR for the updated
>> >> Flink site.
>> >>
>> >> You can find it here: https://github.com/apache/flink-web/pull/44
>> >>
>> >> Please share any feedback!
>> >>
>> >> Thanks,
>> >> Mike
>> >>
>> >> On Fri, Dec 2, 2016 at 6:39 PM, Maximilian Michels <m...@apache.org>
>> wrote:
>> >>
>> >>> The changes look great, Mike! Here's a quick screenshot of the front
>> page:
>> >>> http://pasteboard.co/images/51Tqpm8Ke.png
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>> A quick one liner to paste in your terminal to open a browser window
>> with
>> >>> the changes:
>> >>>
>> >>> git clone https://github.com/wints/flink-web-updates web-updates && cd
>> >>> web-updates && ./build.sh && {./build.sh -p &} && for i in `seq 1 10`;
>> do
>> >>> sleep 1 && curl -Ss http://localhost:4000 && break; done && open
>> >>> http://localhost:4000 >/dev/null
>> >>>
>> >>> On Wed, Nov 30, 2016 at 11:56 AM, Mike Winters <mwi...@gmail.com>
>> wrote:
>> >>> > Hi everyone,
>> >>> >
>> >>> > We've made progress on the new site, and here's a version you can run
>> >>> > locally if you'd like to take a look:
>> >>> > https://github.com/wints/flink-web-updates
>> >>> >
>> >>> > Should take about a minute to get it running:
>> >>> > 1) git clone https://github.com/wints/flink-web-updates.git
>> >>> > 2) ./build.sh -p
>> >>> > 3) http://localhost:4000/
>> >>> >
>> >>> > Feedback is welcome.
>> >>> >
>> >>> > Best,
>> >>> > Mike
>> >>> >
>> >>> > On Thu, Nov 10, 2016 at 3:12 PM, Ufuk Celebi <u...@apache.org> wrote:
>> >>> >
>> >>> >> On 10 November 2016 at 14:46:57, Mike Winters (mwi...@gmail.com)
>> >>> wrote:
>> >>> >> > > @Max, I was also unsure about the left-hand nav as it's a
>> >>> substantial
>> >>> >> > change from the status quo, however, I believe it provides more
>> >>> >> > guidance on
>> >>> >> > a 'logical' order for a new user to move through the site.
>> Definitely
>> >>> >> > open
>> >>> >> > to other approaches.
>> >>> >>
>> >>> >> +1 to try out the left-hand nav.
>> >>> >>
>> >>> >
>> >>> >
>> >>> >
>> >>> > --
>> >>> > -Mike
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> -Mike
>> >>
>> >
>> >
>> >
>> > --
>> > -Mike
>>
>
>
>
> --
> -Mike

Reply via email to