I opened a PR for FLINK-6188: https://github.com/apache/flink/pull/3616 <https://github.com/apache/flink/pull/3616>
This improves the previously very sparse test coverage for timestamp/watermark assigners and fixes the bug. > On 25 Mar 2017, at 10:22, Ufuk Celebi <u...@apache.org> wrote: > > I agree with Aljoscha. > > -1 because of FLINK-6188 > > > On Sat, Mar 25, 2017 at 9:38 AM, Aljoscha Krettek <aljos...@apache.org> wrote: >> I filed this issue, which was observed by a user: >> https://issues.apache.org/jira/browse/FLINK-6188 >> >> I think that’s blocking for 1.2.1. >> >>> On 24 Mar 2017, at 18:57, Ufuk Celebi <u...@apache.org> wrote: >>> >>> RC1 doesn't contain Stefan's backport for the Asynchronous snapshots >>> for heap-based keyed state that has been merged. Should we create RC2 >>> with that fix since the voting period only starts on Monday? I think >>> it would only mean rerunning the scripts on your side, right? >>> >>> – Ufuk >>> >>> >>> On Fri, Mar 24, 2017 at 3:05 PM, Robert Metzger <rmetz...@apache.org> wrote: >>>> Dear Flink community, >>>> >>>> Please vote on releasing the following candidate as Apache Flink version >>>> 1.2 >>>> .1. >>>> >>>> The commit to be voted on: >>>> *732e55bd* (*http://git-wip-us.apache.org/repos/asf/flink/commit/732e55bd >>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/732e55bd>*) >>>> >>>> Branch: >>>> release-1.2.1-rc1 >>>> >>>> The release artifacts to be voted on can be found at: >>>> *http://people.apache.org/~rmetzger/flink-1.2.1-rc1/ >>>> <http://people.apache.org/~rmetzger/flink-1.2.1-rc1/>* >>>> >>>> The release artifacts are signed with the key with fingerprint D9839159: >>>> http://www.apache.org/dist/flink/KEYS >>>> >>>> The staging repository for this release can be found at: >>>> https://repository.apache.org/content/repositories/orgapacheflink-1116 >>>> >>>> ------------------------------------------------------------- >>>> >>>> >>>> The vote ends on Wednesday, March 29, 2017, 3pm CET. >>>> >>>> >>>> [ ] +1 Release this package as Apache Flink 1.2.1 >>>> [ ] -1 Do not release this package, because ... >>
