+1 Important: Please still write in the notes (when closing the issue) the commit hashes for both 1.5 (release-1.5) and 1.6 (master). Otherwise it makes hind-sight digging into the fixed more complicated.
On Thu, Mar 15, 2018 at 3:28 PM, Felix Cheung <felixcheun...@hotmail.com> wrote: > +1 > > ________________________________ > From: Till Rohrmann <trohrm...@apache.org> > Sent: Thursday, March 15, 2018 5:45:14 AM > To: dev@flink.apache.org > Subject: Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as > resolved in 1.6.0 > > +1 for marking bugs as fixed 1.5.0 only > > On Thu, Mar 15, 2018 at 11:09 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > +1 on marking bugs as fixed for 1.5.0 only. > > -------- Original message --------From: Piotr Nowojski < > > pi...@data-artisans.com> Date: 3/15/18 12:48 AM (GMT-08:00) To: > > dev@flink.apache.org Subject: Re: [DISCUSS] Not marking Jira issues as > > resolved in 1.5.0 as resolved in 1.6.0 > > Same as Chesnay > > > > +1 for marking bugs as fixed 1.5.0 only > > > > > On 15 Mar 2018, at 07:57, Chesnay Schepler <ches...@apache.org> wrote: > > > > > > +1 to mark bugs as fixed in 1.5.0 only. > > > > > > On 15.03.2018 01:40, Aljoscha Krettek wrote: > > >> Hi, > > >> > > >> We currently have some issues that are marked as resolved for both > > 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch > and > > the master branch, which will eventually become the branch for 1.6.0. > > >> > > >> I think this can lead to confusion because the release notes are > > created based on that data. Say, we fix a bug "foo" after we created the > > release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the > > release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0 > > release notes with around 50 issues that were never bugs in 1.6.0 because > > they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the > > 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0 > > (because we now had to fix it), but it wasn't. > > >> > > >> I would propose to remove fixVersion 1.6.0 from all issues that have > > 1.5.0 as fixVersion. What do you think? > > >> > > >> On a side note: a bug that is fixed in 1.5.1 should be marked as fixed > > for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1. > > >> > > >> Best, > > >> Aljoscha > > >> > > >> [1] https://issues.apache.org/jira/issues/?jql=project%20% > > 3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D% > > 20unresolved > > > > > > > > > > >
