Thanks for reporting the issues Timo. I think both of them are not blocking the release and should be addressed for the following releases.
Cheers, Till On Thu, May 24, 2018 at 10:52 AM, Timo Walther <[email protected]> wrote: > I tried to build the relase locally but 3 tests failed. 2 are related to > the evironment in which the tests are executed (see [1]) and the other > should have been caught by Travis which did not happen (see last comments > in [2]). > > [1] https://issues.apache.org/jira/browse/FLINK-9424 > [2] https://issues.apache.org/jira/browse/FLINK-9234 > > Timo > > Am 23.05.18 um 17:33 schrieb Till Rohrmann: > > -1 >> >> Piotr just found a race condition between the TM registration at the RM >> and >> slot requests coming from the SlotManager/RM [1]. This is a release >> blocker >> since it affects all deployments. Consequently I have to cancel this RC >> :-( >> >> [1] https://issues.apache.org/jira/browse/FLINK-9427 >> >> On Wed, May 23, 2018 at 5:15 PM, Gary Yao <[email protected]> wrote: >> >> +1 (non-binding) >>> >>> I have run all examples (batch & streaming), and only found a >>> non-blocking >>> issue >>> with TPCHQuery3 [1] which has been introduced a year ago. >>> >>> I have also deployed a cluster with HA enabled on YARN (Hadoop 2.8.3) >>> without >>> problems. >>> >>> [1] https://issues.apache.org/jira/browse/FLINK-9399 >>> >>> On Wed, May 23, 2018 at 4:50 PM, Ted Yu <[email protected]> wrote: >>> >>> +1 >>>> >>>> Checked signatures >>>> Ran test suite >>>> >>>> Due to FLINK-9340 and FLINK-9091, I had to run tests in multiple rounds. >>>> >>>> Cheers >>>> >>>> On Wed, May 23, 2018 at 7:39 AM, Fabian Hueske <[email protected]> >>>> >>> wrote: >>> >>>> +1 (binding) >>>>> >>>>> - checked hashes and signatures >>>>> - checked source archive and didn't find unexpected binary files >>>>> - built from source archive skipping the tests (mvn -DskipTests clean >>>>> install), started a local cluster, and ran an example program. >>>>> >>>>> Thanks, >>>>> Fabian >>>>> >>>>> >>>>> >>>>> 2018-05-23 15:39 GMT+02:00 Till Rohrmann <[email protected]>: >>>>> >>>>> Fabian pointed me to the updated ASF release policy [1] and the >>>>>> >>>>> changes >>> >>>> it >>>>> >>>>>> implies for the checksum files. New releases should no longer >>>>>> >>>>> provide a >>> >>>> MD5 >>>>> >>>>>> checksum file and the sha checksum file should have a proper file >>>>>> >>>>> name >>> >>>> extension `sha512` instead of `sha`. I've updated the release >>>>>> >>>>> artifacts >>> >>>> [2] >>>>> >>>>>> accordingly. >>>>>> >>>>>> [1] https://www.apache.org/dev/release-distribution.html >>>>>> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc5/ >>>>>> >>>>>> Cheers, >>>>>> Till >>>>>> >>>>>> On Wed, May 23, 2018 at 11:18 AM, Piotr Nowojski < >>>>>> >>>>> [email protected]> >>>>> >>>>>> wrote: >>>>>> >>>>>> +1 from me. >>>>>>> >>>>>>> Additionally for this RC5 I did some manual tests to double check >>>>>>> >>>>>> backward >>>>>> >>>>>>> compatibility of the bug fix: >>>>>>> https://issues.apache.org/jira/browse/FLINK-9295 < >>>>>>> https://issues.apache.org/jira/browse/FLINK-9295> >>>>>>> >>>>>>> The issue with this bug fix was that it was merged after 1.5.0 RC4 >>>>>>> >>>>>> but >>>> >>>>> just before 1.5.0 RC5, so it missed release testing. >>>>>>> >>>>>>> Piotrek >>>>>>> >>>>>>> On 23 May 2018, at 09:08, Till Rohrmann <[email protected]> >>>>>>>> >>>>>>> wrote: >>>>> >>>>>> Thanks for the pointer Sihua, I've properly closed FLINK-9070. >>>>>>>> >>>>>>>> On Wed, May 23, 2018 at 4:49 AM, sihua zhou <[email protected] >>>>>>>> >>>>>>> wrote: >>>>>> >>>>>>> Hi, >>>>>>>>> just one minor thing, I found the JIRA release notes seem a bit >>>>>>>>> inconsistent with the this RC. For example, >>>>>>>>> >>>>>>>> https://issues.apache.org/ >>>>>> >>>>>>> jira/browse/FLINK-9058 hasn't been merged yet but included in >>>>>>>>> >>>>>>>> the >>> >>>> release >>>>>>> >>>>>>>> notes, and https://issues.apache.org/jira/browse/FLINK-9070 has >>>>>>>>> >>>>>>>> been >>>>> >>>>>> merged but not included in the relase notes. >>>>>>>>> >>>>>>>>> Best, Sihua >>>>>>>>> >>>>>>>>> >>>>>>>>> On 05/23/2018 09:18，Till Rohrmann<[email protected]> >>>>>>>>> <[email protected]> wrote： >>>>>>>>> >>>>>>>>> Hi everyone, >>>>>>>>> >>>>>>>>> Please review and vote on the release candidate #5 for the >>>>>>>>> >>>>>>>> version >>> >>>> 1.5.0, >>>>>>> >>>>>>>> as follows: >>>>>>>>> [ ] +1, Approve the release >>>>>>>>> [ ] -1, Do not approve the release (please provide specific >>>>>>>>> >>>>>>>> comments) >>>>> >>>>>> >>>>>>>>> The complete staging area is available for your review, which >>>>>>>>> >>>>>>>> includes: >>>>>> >>>>>>> * JIRA release notes [1], >>>>>>>>> * the official Apache source release and binary convenience >>>>>>>>> >>>>>>>> releases >>>> >>>>> to >>>>>> >>>>>>> be >>>>>>> >>>>>>>> deployed to dist.apache.org [2], which are signed with the key >>>>>>>>> >>>>>>>> with >>>> >>>>> fingerprint 1F302569A96CFFD5 [3], >>>>>>>>> * all artifacts to be deployed to the Maven Central Repository >>>>>>>>> >>>>>>>> [4], >>>> >>>>> * source code tag "release-1.5.0-rc5" [5], >>>>>>>>> >>>>>>>>> Please use this document for coordinating testing efforts: [6] >>>>>>>>> >>>>>>>>> Since the newly included fixes affect only individual components >>>>>>>>> >>>>>>>> and >>>> >>>>> are >>>>>> >>>>>>> covered by tests, I will shorten the voting period until >>>>>>>>> >>>>>>>> tomorrow >>> >>>> 5:30pm >>>>>> >>>>>>> CET. It is adopted by majority approval, with at least 3 PMC >>>>>>>>> >>>>>>>> affirmative >>>>>> >>>>>>> votes. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Your friendly Release Manager >>>>>>>>> >>>>>>>>> [1] >>>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >>>>>>>>> projectId=12315522&version=12341764 >>>>>>>>> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc5/ >>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>>>>>>> [4] https://repository.apache.org/content/repositories/ >>>>>>>>> orgapacheflink-1160/ >>>>>>>>> [5] >>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h= >>>>>>>>> 841bfe4cceecc9cd6ad3d568173fdc0149a5dc9b >>>>>>>>> [6] >>>>>>>>> https://docs.google.com/document/d/ >>>>>>>>> >>>>>>>> 1C1WwUphQj597jExWAXFUVkLH9Bi7- >>> >>>> ir6drW9BgB8Ezo/edit?usp=sharing >>>>>>>>> >>>>>>>>> Pro-tip: you can create a settings.xml file with these contents: >>>>>>>>> >>>>>>>>> <settings> >>>>>>>>> <activeProfiles> >>>>>>>>> <activeProfile>flink-1.5.0</activeProfile> >>>>>>>>> </activeProfiles> >>>>>>>>> <profiles> >>>>>>>>> <profile> >>>>>>>>> <id>flink-1.5.0</id> >>>>>>>>> <repositories> >>>>>>>>> <repository> >>>>>>>>> <id>flink-1.5.0</id> >>>>>>>>> <url> >>>>>>>>> >>>>>>>>> https://repository.apache.org/content/repositories/ >>>>>>>>> >>>>>>>> orgapacheflink-1160/ >>>>>> >>>>>>> </url> >>>>>>>>> </repository> >>>>>>>>> <repository> >>>>>>>>> <id>archetype</id> >>>>>>>>> <url> >>>>>>>>> >>>>>>>>> https://repository.apache.org/content/repositories/ >>>>>>>>> >>>>>>>> orgapacheflink-1160/ >>>>>> >>>>>>> </url> >>>>>>>>> </repository> >>>>>>>>> </repositories> >>>>>>>>> </profile> >>>>>>>>> </profiles> >>>>>>>>> </settings> >>>>>>>>> >>>>>>>>> And reference that in you maven commands via --settings >>>>>>>>> path/to/settings.xml. This is useful for creating a quickstart >>>>>>>>> >>>>>>>> based >>>> >>>>> on >>>>>> >>>>>>> the >>>>>>> >>>>>>>> staged release and for building against the staged jars. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>> >
