Hi Yazdan, First of all, thank you for contributing to Flink!
As Chesnay said, many of the Flink committers try to review pull requests in a timely manner. However, everybody has to put time aside to review a PR. Many committers are either working on features themselves or review PRs in their free time. IMO, a good approach to have your PRs quickly reviewed is to interact with the community *before* opening a PR. If you want to contribute a new feature, you should create a Jira issue and ask for feedback. If you want to work on a feature that was proposed by somebody else, ask on the Jira issue whether this is a relevant problem or desired feature. You can also reach out to the dev mailing list. For larger changes you should also propose a solution such that the design can be discussed beforehand. Once somebody told you that there is interest in a feature (and agreed with your approach), the chances are good that your PR is reviewed. Of course, you don't need to start a discussion for bug fixes that touch only a few lines of code or improve the documentation. Small PRs are usually, quickly reviewed and merged. Best, Fabian 2018-06-09 11:58 GMT+02:00 Chesnay Schepler <ches...@apache.org>: > Hello, > > These kind of lists are imo misguided as they setup false expectations. > They imply that "If I ping person X at time Y I will get a fast review", > which is just not true. > > Thus, allow me to answer your questions: > > “Who should I tag in my PR for code review?” > > You shouldn't tag anyone in PRs. Contributors do not pick reviewers, > reviewers pick contributions. > > “How long does it take to get a first response from the reviewer?” > > We do not provide any guarantees for a timely review. > As far as Apache Flink is concerned reviews are done on a volunteer basis, > thus enforcing any kind of "work assignment" will not happen. > > > On 09.06.2018 03:19, Yaz Sh wrote: > >> Hi Flink Community, >> >> I am working with Flink for last couple of months and still learning it. >> Recently, I have started as a contributor in Flink to perform some minor >> changes and I am very excited to start working on bigger tasks. >> Questions I always have in mind, when I make a PR, are “Who should I tag >> in my PR for code review?” and “How long does it take to get a first >> response from the reviewer?” >> >> Usually if there is a Jira ticket reported on the task, I will tag >> reporter as well as people who commented on it. Also, I look at other PRs >> with similar topics and try to find out who is doing code review for those >> PRs. >> >> Here I would like to share a proposal to create a "Code Reviewer List" as >> part of Flink contribution guideline. This list would provide name of code >> reviewers, their availabilities, topics of interest as well as turnaround >> time for initial code review. This will provide good starting point for new >> contributors like myself to find a code reviewer based on a topic he/she is >> contributing. >> >> I would appreciate if Flink community shares thoughts on this proposal! >> >> Cheers, >> Yazdan >> > > >
