+1 to Chesnay's proposal to create a new RC with a shortened voting period.
On Tue, Jul 10, 2018 at 2:02 PM Chesnay Schepler <ches...@apache.org> wrote: > I've opened a PR for the metric issue: > https://github.com/apache/flink/pull/6292 > > Given that we've already got the required votes and still got 24h left, > I would like to cancel this vote, create a new RC this evening with a > shortended > voting period (24h). > > Virtually all checks made so far (excluding the signing) would still apply > to the new RC. > > On 10.07.2018 13:12, Chesnay Schepler wrote: > > +1 > > > > * start local cluster using start-cluster.bat and checked log files > > * uploaded and submitted multiple jobs through WebUI > > > > On 10.07.2018 12:47, Chesnay Schepler wrote: > >> This issue has already affected 1.5.0 (in other places). > >> > >> I rescind my -1 and will continue testing. > >> > >> On 10.07.2018 12:45, Chesnay Schepler wrote: > >>> I've linked the wrong jira: > >>> https://issues.apache.org/jira/browse/FLINK-9789 > >>> > >>> On 10.07.2018 12:42, Chesnay Schepler wrote: > >>>> -1 > >>>> > >>>> I found an issue where watermark metrics override each other, which > >>>> would be a regression to 1.5.0: > >>>> > >>>> https://issues.apache.org/jira/browse/FLINK-8731 > >>>> > >>>> On 10.07.2018 11:12, Gary Yao wrote: > >>>>> +1 (non-binding) > >>>>> > >>>>> Ran Jepsen tests [1] on EC2 for around 8 hours without issues. > >>>>> > >>>>> [1] https://github.com/apache/flink/pull/6240 > >>>>> > >>>>> On Tue, Jul 10, 2018 at 11:00 AM, Aljoscha Krettek > >>>>> <aljos...@apache.org> > >>>>> wrote: > >>>>> > >>>>>> +1 (binding) > >>>>>> > >>>>>> - verified signatures and checksums > >>>>>> - built successfully from source > >>>>>> > >>>>>>> On 10. Jul 2018, at 09:48, Jeff Zhang <zjf...@gmail.com> wrote: > >>>>>>> > >>>>>>> +1. > >>>>>>> > >>>>>>> Build form source successfully. > >>>>>>> > >>>>>>> Tested scala-shell in local and yarn mode, works well. > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> Till Rohrmann <trohrm...@apache.org>于2018年7月10日周二 > >>>>>>> 下午3:37写道: > >>>>>>> > >>>>>>>> +1 (binding) > >>>>>>>> > >>>>>>>> - Verified that no new dependencies were added for which the > >>>>>>>> LICENSE and > >>>>>>>> NOTICE files need to be adapted. > >>>>>>>> - Build 1.5.1 from the source artifact > >>>>>>>> - Run flink-end-to-end tests for 12 hours for the 1.5.1 Hadoop 2.7 > >>>>>> binary > >>>>>>>> artifact > >>>>>>>> - Run Jepsen tests for 12 hours for the 1.5.1 Hadoop 2.8 binary > >>>>>>>> artifact > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Till > >>>>>>>> > >>>>>>>> On Sat, Jul 7, 2018 at 10:13 AM vino yang <yanghua1...@gmail.com> > >>>>>> wrote: > >>>>>>>>> +1, but announcement blog should change the release date. > >>>>>>>>> > >>>>>>>>> 2018-07-07 7:31 GMT+08:00 Ted Yu <yuzhih...@gmail.com>: > >>>>>>>>> > >>>>>>>>>> +1 > >>>>>>>>>> > >>>>>>>>>> Checked signatures of artifacts > >>>>>>>>>> > >>>>>>>>>> Ran test suite > >>>>>>>>>> > >>>>>>>>>> On Fri, Jul 6, 2018 at 11:42 AM Yaz Sh <yazda...@gmail.com> > >>>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> +1 > >>>>>>>>>>> > >>>>>>>>>>> Tests have been done on OS X > >>>>>>>>>>> > >>>>>>>>>>> - Ran in cluster mode ./bin/start-cluster.sh > >>>>>>>>>>> - Checked that *.out files are empty > >>>>>>>>>>> - Stopped cluster ./bin/stop-cluster.sh > >>>>>>>>>>> - Checked for No Exceptions on log output > >>>>>>>>>>> > >>>>>>>>>>> - Test Examples via WebUI > >>>>>>>>>>> - Test Example via CLI with different flags (-d, -c, -q, -p) > >>>>>>>>>>> > >>>>>>>>>>> - Added more task Managers via flink-config.yml and re-ran the > >>>>>>>> Examples > >>>>>>>>>>> - Added more task Manager via ./bin/taskmanager.sh and > >>>>>>>>>>> re-ran the > >>>>>>>>>> Examples > >>>>>>>>>>> - Checked “checksum” for all packages > >>>>>>>>>>> - Checked GPG signature for all packages > >>>>>>>>>>> - Checked the README.md > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> Cheers, > >>>>>>>>>>> Yazdan > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>>> On Jul 6, 2018, at 11:09 AM, Chesnay Schepler > >>>>>>>>>>>> <ches...@apache.org> > >>>>>>>>>>> wrote: > >>>>>>>>>>>> Hi everyone, > >>>>>>>>>>>> Please review and vote on the release candidate #2 for the > >>>>>>>>>>>> version > >>>>>>>>>>> 1.5.1, as follows: > >>>>>>>>>>>> [ ] +1, Approve the release > >>>>>>>>>>>> [ ] -1, Do not approve the release (please provide specific > >>>>>>>> comments) > >>>>>>>>>>>> > >>>>>>>>>>>> The complete staging area is available for your review, which > >>>>>>>>> includes: > >>>>>>>>>>>> * JIRA release notes [1], > >>>>>>>>>>>> * the official Apache source release and binary convenience > >>>>>>>> releases > >>>>>>>>> to > >>>>>>>>>>> be deployed to dist.apache.org [2], which are signed with > >>>>>>>>>>> the key > >>>>>>>> with > >>>>>>>>>>> fingerprint 11D464BA [3], > >>>>>>>>>>>> * all artifacts to be deployed to the Maven Central > >>>>>>>>>>>> Repository [4], > >>>>>>>>>>>> * source code tag "release-1.5.1-rc2" [5], > >>>>>>>>>>>> * website pull request listing the new release and adding > >>>>>>>>> announcement > >>>>>>>>>>> blog post [6]. > >>>>>>>>>>>> The vote will be open for at least 72 hours. It is adopted by > >>>>>>>>> majority > >>>>>>>>>>> approval, with at least 3 PMC affirmative votes. > >>>>>>>>>>>> Thanks, > >>>>>>>>>>>> Chesnay > >>>>>>>>>>>> > >>>>>>>>>>>> [1] > >>>>>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? > >>>>>>>>>> projectId=12315522&version=12343053 > >>>>>>>>>>>> [2] https://dist.apache.org/repos/dist/dev/flink/1.5.1/ > >>>>>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>>>>>>>>>> [4] > >>>>>>>> > https://repository.apache.org/content/repositories/orgapacheflink-1170 > >>>>>>>> > >>>>>>>>>>>> [5] > >>>>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h= > >>>>>>>>>> refs/tags/release-1.5.1-rc2 > >>>>>>>>>>>> [6] https://github.com/apache/flink-web/pull/112 > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>> > >>>>>> > >>>> > >>>> > >>> > >>> > >> > >> > > > > > >