+1 I did - verify all changes between 4.0 and 5.0 - check signature and hash of the source release - build a work-in-progress branch for Scala 2.12 support using the new shaded asm6 package
> On 10. Oct 2018, at 15:11, Chesnay Schepler <ches...@apache.org> wrote: > > Hi everyone, > Please review and vote on the release candidate #1 for the version 5.0, as > follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > This release > * adds jackson-dataformat-csv to the the shaded-jackson module (used for CSV > table factory) > * enables dependency convergence > * adds a new flink-shaded-asm-6 module (required for scala 2.12 and java 9) > > The complete staging area is available for your review, which includes: > * JIRA release notes [1], > * the official Apache source release to be deployed to dist.apache.org [2], > which are signed with the key with fingerprint 11D464BA [3], > * all artifacts to be deployed to the Maven Central Repository [4], > * source code tag "release-5.0-rc1" [5]. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Chesnay > > [1] > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12343750 > [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-5.0-rc1/ > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > [4] https://repository.apache.org/content/repositories/orgapacheflink-1182/ > [5] > https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=shortlog;h=refs/tags/5.0-rc1