+1

- manually checked the commit diff and could not sport any issues
- run mvn clean verify locally with success
- run a couple of e2e tests locally with success

Thanks,
Timo

Am 19.12.18 um 18:36 schrieb Aljoscha Krettek:
+1

- signatures/hashes are ok
- manually checked the logs after running an example on a local cluster

There is this exception in the client log when running without Hadoop in the 
classpath:

2018-12-19 18:34:54,876 WARN  org.apache.flink.client.cli.CliFrontend           
            - Could not load CLI class 
org.apache.flink.yarn.cli.FlinkYarnSessionCli.
java.lang.NoClassDefFoundError: org/apache/hadoop/yarn/exceptions/YarnException
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:264)
        at 
org.apache.flink.client.cli.CliFrontend.loadCustomCommandLine(CliFrontend.java:1218)
        at 
org.apache.flink.client.cli.CliFrontend.loadCustomCommandLines(CliFrontend.java:1174)
        at org.apache.flink.client.cli.CliFrontend.main(CliFrontend.java:1100)
Caused by: java.lang.ClassNotFoundException: 
org.apache.hadoop.yarn.exceptions.YarnException
        at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 5 more

This is not a problem, though it might seem strange to users.

On 18. Dec 2018, at 16:52, Chesnay Schepler <ches...@apache.org> wrote:

+1

- signing key present in KEYS
- signatures ok
- src contains no binaries
- binary not missing any jars
- tag exists
- release notes classification/names seem appropriate
- maven artifacts not missing any jars

On 18.12.2018 06:27, Thomas Weise wrote:
Hi everyone,
Please review and vote on the release candidate #1 for the version
1.5.6, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release and binary convenience releases to
be deployed to dist.apache.org [2], which are signed with the key with
fingerprint D920A98C [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-1.5.6-rc1" [5].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Thomas

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12344315
[2] https://dist.apache.org/repos/dist/dev/flink/flink-1.5.6-rc1/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1199/
[5]
https://gitbox.apache.org/repos/asf?p=flink.git;a=tag;h=refs/tags/release-1.5.6-rc1


Reply via email to