You do have a point, but your output is mostly incorrect.
There are only 3 modules that have a suffix, which don't need it:
*
flink-connector-hive
*
flink-queryable-state-client-java
*
flink-table-api-scala
The remaining do need it since they have dependencies with a
scala-suffix (mostly on runtime and streaming-java).
Your change does make sense to me, but there's likely another issue in
the preceding logic that determines which module is scala-free.
flink-tests for example should not be considered scala-free, since it
relies on flink-runtime which contains scala and hence the scala-lang
dependencies, but it apparently is given that your change detects something.
On 22/05/2019 13:31, jincheng sun wrote:
Hi all,
I find a shell issue in `verify_scala_suffixes.sh`(line 145) as follows:
```
grep "${module}_\d\+\.\d\+</artifactId>" "{}"
```
This code want to find out all modules that the module's `artifactId` with
a `scala_binary_version` suffix.
but the problem is our all `artifactId` value is in the pattern of
`XXX_${scala.binary.version}`, such as:
```
<artifactId>flink-tests_${scala.binary.version}</artifactId>
```
then the find out always empty, so this check did not take effect.
When I correct the script as follows:
```
grep "${module}_\\${scala.binary.version}</artifactId>" "{}"
```
we find there more than 10 modules have incorrect `artifactId` config. as
follows:
1.flink-connector-hive
2.flink-fs-tests
3.flink-queryable-state-client-java
4.flink-sql-connector-elasticsearch6
5.flink-sql-connector-kafka
6.flink-sql-connector-kafka-0.10
7.flink-sql-connector-kafka-0.11
8.flink-sql-connector-kafka-0.9
9.flink-table-api-scala
10.flink-tests
11.flink-yarn-tests
And to fix this issue, we need a big change, such as:
- correct the `artifactId` config.
- update the dependency of relation modules.
- release the connector into the repo.
- update some of the doc for `connector.zh.md` and `connector.md`.
- others
>From the points of my view, It's better to fix this issue before the flink
1.9 release.
What do you think?
NOTE: Please remind me if I have a missing above!
1. The script code change:
https://github.com/sunjincheng121/flink/commit/736f16a8a76aaef1018cc754f0effec119e43120
2. The CI test result: https://api.travis-ci.org/v3/job/535719615/log.txt
Regards,
Jincheng
