Thanks for the quick fix. 

Best,
Haibo

在 2019-06-20 21:24:47,"jincheng sun" <sunjincheng...@gmail.com> 写道:
>Hi Haibo,
>
>The issue is fixed, great thanks for your timely report on this issue!
>
>Best,
>Jincheng
>
>
>jincheng sun <sunjincheng...@gmail.com> 于2019年6月20日周四 下午9:04写道:
>
>> Hi flink devs:
>>
>> Normally, in order not to affect the merge of the followup PR, we need to
>> revert the problematic commit, but since Dian quickly opens the hotfix PR,
>> this time we take the hotfix.
>>
>> So great thanks to Dian!
>>
>> Hi Dian, you are right,the test fail caused by the PR #8786, and I
>> completely agree all the committers should check the Travis success before
>> merging.
>>
>> Your PR looks good, I'll merge it after the test passed! (waiting test
>> pass)
>>
>> Best,
>> Jincheng
>>
>> jincheng sun <sunjincheng...@gmail.com> 于2019年6月20日周四 下午8:30写道:
>>
>>> Great thanks for the help to fix it Dian!  I'll merge it.
>>>
>>>
>>>
>>> Dian Fu <dian0511...@gmail.com> 于2019年6月20日周四 下午7:50写道:
>>>
>>>> Hi Haibo,
>>>>
>>>> Thanks a lot for report this bug. I guess it's caused by this PR:
>>>> https://github.com/apache/flink/pull/8786 <
>>>> https://github.com/apache/flink/pull/8786> @Bowen. I think we'd better
>>>> merge the code ONLY after the travis passed, especially when the changes
>>>> are not just hotfix/documentation. Anyway, I'll try to provide a fix ASAP.
>>>>
>>>> Regards,
>>>> Dian
>>>>
>>>> > 在 2019年6月20日,下午6:15,Haibo Sun <sunhaib...@163.com> 写道:
>>>> >
>>>> > Hi, guys
>>>> >
>>>> >
>>>> > I noticed that all of the Travis tests reported a number of failures
>>>> as following. Is anyone working on this problem?
>>>> >
>>>> >
>>>> > ______________________ CatalogTestBase.test_table_exists
>>>> _______________________
>>>> >
>>>> > self = <pyflink.table.tests.test_catalog.CatalogTestBase
>>>> testMethod=test_table_exists>
>>>> >
>>>> >    def test_table_exists(self):
>>>> >>      self.catalog.create_database(self.db1, self.create_db(), False)
>>>> >
>>>> > pyflink/table/tests/test_catalog.py:491:
>>>> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>> _ _ _ _ _
>>>> >
>>>> >    @staticmethod
>>>> >    def create_db():
>>>> >        gateway = get_gateway()
>>>> >>      j_database = gateway.jvm.GenericCatalogDatabase({"k1": "v1"},
>>>> CatalogTestBase.test_comment)
>>>> > E       TypeError: 'JavaPackage' object is not callable
>>>> >
>>>> >
>>>> > pyflink/table/tests/test_catalog.py:78: TypeError
>>>> >
>>>> >
>>>> >
>>>> >
>>>> > Best,
>>>> > Haibo
>>>> >
>>>> >
>>>> >
>>>>
>>>>

Reply via email to