Hi Tison,
To clarify your proposal. You are proposing to actually drop the `final`
keyword from the parameters and we should implicilty assume that it’s always
there (in other words, we shouldn’t be modifying the parameters). Did I
understand this correctly?
Piotrek
> On 1 Oct 2019, at 21:44, Zili Chen <wander4...@gmail.com> wrote:
>
> Hi devs,
>
> Coming from this discussion[1] I'd like to propose that in Flink codebase
> we suggest a code style
> that parameters of method are always final. Almost everywhere parameters of
> method are final
> already and if we have such consensus we can prevent redundant final
> modifier in method
> declaration so that we survive from those noise.
>
> Here are some cases that might require to modify a parameter.
>
> 1. to set default; especially if (param == null) { param = ... }
> 2. to refine parameter; it is in pattern if ( ... ) { param =
> refine(param); }
>
> Either of the cases we can move the refine/set default logics to the caller
> or select another
> name for the refined value case by case.
>
> Looking forward to your feedbacks :-)
>
> Best,
> tison.
>
> [1] https://github.com/apache/flink/pull/9788#discussion_r329314681
