+1 - Verify that the source archives do not contains any binaries - Start the cluster locally and ran some examples successfully
Best, Kurt On Mon, Oct 14, 2019 at 4:32 AM Jark Wu <imj...@gmail.com> wrote: > Thanks @Hequn and @Yun Tang, I set the fixVersion of FLINK-14385 to 1.8.3 > and 1.9.2. > > Btw, I would really appreciate if any PMC member could help with the > verification. > I hope we can release 1.9.1 this week. > The vote will still be open until we reach at least 3 binding votes or any > blocker issue is found. > > Thanks, > Jark > > > 在 2019年10月14日，02:11，Yun Tang <myas...@live.com> 写道： > > > > I think FLINK-14385<https://issues.apache.org/jira/browse/FLINK-14385> > is not introduced from release-1.9 but since when we decide to release > hadoop-free Flink form 1.8 [1] > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-11266 > > > > Best > > Yun Tang > > ________________________________ > > From: Hequn Cheng <chenghe...@gmail.com> > > Sent: Sunday, October 13, 2019 17:28 > > To: dev <dev@flink.apache.org> > > Subject: Re: [VOTE] Release 1.9.1, release candidate #1 > > > > +1 (non-binding) > > > > Do the following checks and all are success. > > - Verified signatures and hashes. > > - Built from the source archive. > > - Check repository contains all artifacts. > > - Test WordCount on a local standalone cluster. > > a. Both streaming and batch > > b. Web UI works fine > > - Test WordCount on yarn cluster, with 4 nodes. > > a. Both streaming and batch > > b. Web UI works fine > > c. Read write hdfs files. > > d. Test session mode and non-session mode. > > > > Minor comments(not blocker) > > - One comment about the website pr. > > - Found an issue that there are > > ClassNotFoundException(java.lang.ClassNotFoundException: > > org.apache.hadoop.yarn.exceptions.YarnException) when run the setup > > example(under Local Flink Cluster). It may be confusing for new users and > > would be nice if can be improved. ( > > https://issues.apache.org/jira/browse/FLINK-14385) > > > > Best, Hequn > > > > On Sat, Oct 12, 2019 at 6:01 PM Jark Wu <imj...@gmail.com> wrote: > > > >> Hi Jingsong, > >> > >> Thanks for verifying. I updated the fixVersion to 1.9.2 for these > issues. > >> > >> Best, > >> Jark > >> > >>> 在 2019年10月12日，16:45，Jingsong Li <jingsongl...@gmail.com> 写道： > >>> > >>> +1 (non-binding) > >>> > >>> - Check if checksums files match the corresponding release files > >>> - Check if GPG files match the corresponding release files > >>> - Verify that the source archives do not contains any binaries > >>> - Build the source with Maven to ensure all source files have Apache > >> headers > >>> - Check that all POM files point to the same version (1.9.1) > >>> - Start a local cluster both Scala 2.11 and 2.12, and shut down. > verified > >>> out and log, verified we ui. run examples. > >>> All succeeded. > >>> > >>> Hi Jark, there are some JIRA issue still use fix version 1.9.0, do you > >> need > >>> modify fix version? > >>> https://issues.apache.org/jira/browse/FLINK-14328 > >>> https://issues.apache.org/jira/browse/FLINK-14327 > >>> https://issues.apache.org/jira/browse/FLINK-14215 > >>> https://issues.apache.org/jira/browse/FLINK-14072 > >>> https://issues.apache.org/jira/browse/FLINK-12576 > >>> > >>> Best, > >>> Jingsong Lee > >>> > >>> > >>> On Wed, Oct 9, 2019 at 3:32 PM Jark Wu <imj...@gmail.com> wrote: > >>> > >>>> +1 from my side. > >>>> > >>>> - checked signatures and hashes > >>>> - checked that all POM files point to the same version > >>>> - verified that the source archives do not contains any binaries > >>>> - build the source release with Scala 2.12 and Scala 2.11 successfully > >>>> - manually verified the diff pom files between 1.9.0 and 1.9.1 to > check > >>>> dependencies, looks good > >>>> - started cluster for both Scala 2.11 and 2.12, ran examples, verified > >> web > >>>> ui and log output, nothing unexpected > >>>> > >>>> Best, > >>>> Jark > >>>> > >>>> On Wed, 9 Oct 2019 at 11:18, Jark Wu <imj...@gmail.com> wrote: > >>>> > >>>>> Thanks Jincheng and Till, then let's keep on verifying the RC1. > >>>>> > >>>>> Best, > >>>>> Jark > >>>>> > >>>>> On Wed, 9 Oct 2019 at 11:00, jincheng sun <sunjincheng...@gmail.com> > >>>>> wrote: > >>>>> > >>>>>> I think we should create the new RC when we find the blocker issues. > >>>>>> We can looking forward the other check result, we can add the fix of > >>>>>> FLINK-14315 in to 1.9.1 only we find the blockers. > >>>>>> > >>>>>> Best, > >>>>>> Jincheng > >>>>>> > >>>>>> Till Rohrmann <trohrm...@apache.org> 于2019年10月8日周二 下午8:20写道： > >>>>>> > >>>>>>> FLINK-14315 has been merged into the release-1.9 branch. I've > marked > >>>> the > >>>>>>> fix version of this ticket as 1.9.2. If we should create a new RC, > >> then > >>>>>>> we > >>>>>>> could include this fix. If this happens, then we need to update the > >> fix > >>>>>>> version to 1.9.1. > >>>>>>> > >>>>>>> Cheers, > >>>>>>> Till > >>>>>>> > >>>>>>> On Tue, Oct 8, 2019 at 1:51 PM Till Rohrmann <trohrm...@apache.org > > > >>>>>>> wrote: > >>>>>>> > >>>>>>>> If people already spent time on verifying the current RC I would > >> also > >>>>>>> be > >>>>>>>> fine to release the fix for FLINK-14315 with Flink 1.9.2. > >>>>>>>> > >>>>>>>> I will try to merge the PR as soon as possible. When I close the > >>>>>>> ticket, I > >>>>>>>> will update the fix version field to 1.9.2. > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Till > >>>>>>>> > >>>>>>>> On Tue, Oct 8, 2019 at 4:43 AM Jark Wu <imj...@gmail.com> wrote: > >>>>>>>> > >>>>>>>>> Hi Zili, > >>>>>>>>> > >>>>>>>>> Thanks for reminding me this, because of the Chinese National Day > >>>> and > >>>>>>>>> Flink Forward Europe, > >>>>>>>>> we didn't receive any verification on the 1.9.1 RC1. And I guess > we > >>>>>>> have > >>>>>>>>> to extend the voting time after Flink Forward. > >>>>>>>>> So I'm fine to have FLINK-14315 and rebuild another RC. What do > you > >>>>>>> think > >>>>>>>>> @Till @Jincheng? > >>>>>>>>> > >>>>>>>>> I guess FLINK-14315 will be merged soon as it is approved 4 days > >>>> ago? > >>>>>>>>> Could you help to merge it once it is passed ? @Zili Chen > >>>>>>>>> <wander4...@gmail.com> > >>>>>>>>> > >>>>>>>>> Best, > >>>>>>>>> Jark > >>>>>>>>> > >>>>>>>>> On Tue, 8 Oct 2019 at 09:14, Zili Chen <wander4...@gmail.com> > >>>> wrote: > >>>>>>>>> > >>>>>>>>>> Hi Jark, > >>>>>>>>>> > >>>>>>>>>> I notice a critical bug[1] is marked resolved in 1.9.1 but given > >>>>>>> 1.9.1 > >>>>>>>>>> has been cut I'd like to throw the issue here so that we're sure > >>>>>>>>>> whether or not it is included in 1.9.1. > >>>>>>>>>> > >>>>>>>>>> Best, > >>>>>>>>>> tison. > >>>>>>>>>> > >>>>>>>>>> [1] https://issues.apache.org/jira/browse/FLINK-14315 > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> Jark Wu <imj...@gmail.com> 于2019年9月30日周一 下午3:25写道： > >>>>>>>>>> > >>>>>>>>>>> Hi everyone, > >>>>>>>>>>> > >>>>>>>>>>> Please review and vote on the release candidate #1 for the > >> version > >>>>>>>>>>> 1.9.1, > >>>>>>>>>>> as follows: > >>>>>>>>>>> [ ] +1, Approve the release > >>>>>>>>>>> [ ] -1, Do not approve the release (please provide specific > >>>>>>> comments) > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> The complete staging area is available for your review, which > >>>>>>> includes: > >>>>>>>>>>> * JIRA release notes [1], > >>>>>>>>>>> * the official Apache source release and binary convenience > >>>>>>> releases to > >>>>>>>>>>> be > >>>>>>>>>>> deployed to dist.apache.org [2], which are signed with the key > >>>> with > >>>>>>>>>>> fingerprint E2C45417BED5C104154F341085BACB5AEFAE3202 [3], > >>>>>>>>>>> * all artifacts to be deployed to the Maven Central Repository > >>>> [4], > >>>>>>>>>>> * source code tag "release-1.9.1-rc1" [5], > >>>>>>>>>>> * website pull request listing the new release and adding > >>>>>>> announcement > >>>>>>>>>>> blog > >>>>>>>>>>> post [6]. > >>>>>>>>>>> > >>>>>>>>>>> The vote will be open for at least 72 hours. > >>>>>>>>>>> Please cast your votes before *Oct. 3th 2019, 08:00 UTC*. > >>>>>>>>>>> > >>>>>>>>>>> It is adopted by majority approval, with at least 3 PMC > >>>> affirmative > >>>>>>>>>>> votes. > >>>>>>>>>>> > >>>>>>>>>>> Thanks, > >>>>>>>>>>> Jark > >>>>>>>>>>> > >>>>>>>>>>> [1] > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>> > >>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346003 > >>>>>>>>>>> [2] > >> https://dist.apache.org/repos/dist/dev/flink/flink-1.9.1-rc1/ > >>>>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>>>>>>>>> [4] > >>>>>>>>>>> > >>>>>>> > >>>> > https://repository.apache.org/content/repositories/orgapacheflink-1272/ > >>>>>>>>>>> [5] > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>> > >>>> > >> > https://github.com/apache/flink/commit/4d56de81cb692c68a7d1dbfff13087a5079a8252 > >>>>>>>>>>> [6] https://github.com/apache/flink-web/pull/274 > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>> > >>>>>> > >>>> > >>> > >>> > >>> -- > >>> Best, Jingsong Lee > >> > >> > >
