Hi all, +1 from my side.
Given the current state of this voting thread, FLIP-74 is accepted with 3 binding vote and 2 non-binding vote. Thanks for your participation! I will update the wiki to reflect that the result of the vote. Best, tison. Zili Chen <wander4...@gmail.com> 于2019年10月11日周五 下午8:48写道： > Well. Then I'd remove the requirement to change cancelWithSavepoint > but remain why we exclude it from JobClient. > > We might still change signature to completable future for a consistent > async view of ClusterClient but it is quite an implement detail and we > don't stick to it on FLIP level. > > Best, > tison. > > > Kostas Kloudas <kklou...@gmail.com> 于2019年10月11日周五 下午7:36写道： > >> Hi Tison, >> >> Thanks for integrating the comments! >> >> +1 for accepting the FLIP from my side. >> What I meant is that in the Proposed Changes section, the FLIP still >> has that the cancelWithSavepoin(jobId, savepointDir) of the >> clusterClient should change to return a CompletableFuture. I believe >> that this change is redundant as we will not need it for the >> JobClient. I should have been more clear on what I meant before. >> >> Cheers, >> Kostas >> >> On Fri, Oct 11, 2019 at 11:51 AM Zili Chen <wander4...@gmail.com> wrote: >> > >> > Hi Kostas, >> > >> > Thanks for your reply. >> > >> > (1) cancelWithSavepoint() has already been excluded from the FLIP. But >> > to emphasize that we make the decision to exclude it I add it to reject >> > alternatives. >> > >> > (2) Updated FLIP to reflect the consensus :-) >> > >> > Best, >> > tison. >> > >> > >> > Kostas Kloudas <kklou...@gmail.com> 于2019年10月11日周五 下午5:12写道： >> > >> > > Hi all, >> > > >> > > I only have two minor comments before voting and they have to do with >> > > the following: >> > > >> > > 1) In the discussion, we agreed to remove the cancelWithSavepoint() >> > > from the JobClient as this is deprecated in the rest API. This is not >> > > in the FLIP. >> > > 2) The section "ClusterDescriptor or Executor(FLIP-73)(integration)" >> > > does not reflect our discussion where we said that for now only the >> > > Executor#execute() will give you the JobClient and there will be a >> > > separate discussion about alternative ways of exposing the JobClient. >> > > >> > > I think that these points should be updated in order for the FLIP to >> > > reflect the discussion in the ML thread. >> > > >> > > Cheers, >> > > Kostas >> > > >> > > On Fri, Oct 11, 2019 at 10:58 AM Biao Liu <mmyy1...@gmail.com> wrote: >> > > > >> > > > +1 (non-binding), glad to have this improvement! >> > > > >> > > > Thanks, >> > > > Biao /'bɪ.aʊ/ >> > > > >> > > > >> > > > >> > > > On Fri, 11 Oct 2019 at 14:44, Jeff Zhang <zjf...@gmail.com> wrote: >> > > > >> > > > > +1， overall design make sense to me >> > > > > >> > > > > SHI Xiaogang <shixiaoga...@gmail.com> 于2019年10月11日周五 上午11:15写道： >> > > > > >> > > > > > +1. The interface looks fine to me. >> > > > > > >> > > > > > Regards, >> > > > > > Xiaogang >> > > > > > >> > > > > > Zili Chen <wander4...@gmail.com> 于2019年10月9日周三 下午2:36写道： >> > > > > > >> > > > > > > Given the ongoing FlinkForward Berlin event, I'm going to >> extend >> > > > > > > this vote thread with a bit of period, said until Oct. >> > > 11th(Friday). >> > > > > > > >> > > > > > > Best, >> > > > > > > tison. >> > > > > > > >> > > > > > > >> > > > > > > Zili Chen <wander4...@gmail.com> 于2019年10月7日周一 下午4:15写道： >> > > > > > > >> > > > > > > > Hi all, >> > > > > > > > >> > > > > > > > I would like to start the vote for FLIP-74[1], which is >> > > discussed and >> > > > > > > > reached a consensus in the discussion thread[2]. >> > > > > > > > >> > > > > > > > The vote will be open util Oct. 9th(72h starting on >> Oct.7th), >> > > unless >> > > > > > > > there is an objection or not enough votes. >> > > > > > > > >> > > > > > > > Best, >> > > > > > > > tison. >> > > > > > > > >> > > > > > > > [1] >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-74%3A+Flink+JobClient+API >> > > > > > > > [2] >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > >> https://lists.apache.org/x/thread.html/b2e22a45aeb94a8d06b50c4de078f7b23d9ff08b8226918a1a903768@%3Cdev.flink.apache.org%3E >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > Best Regards >> > > > > >> > > > > Jeff Zhang >> > > > > >> > > >> >
