+1 (non-binding) * Test flink-shaded-jackson 9.0 against release-1.8 and release-1.9 (borrow the idea from @Ufuk) - 1.9 code: https://github.com/hequn8128/flink/commits/test_flink_shade_jackson_9.0_and_jackson_2.10.1_on_flink_1.9 - 1.9 travis: https://travis-ci.org/hequn8128/flink/builds/615861825 - 1.8 code: https://github.com/hequn8128/flink/commits/test_flink_shade_jackson_9.0_and_jackson_2.10.1_on_flink_1.8 - 1.8 travis: https://travis-ci.org/hequn8128/flink/builds/615866914 * Built from source archive successfully. * Signatures and hash are correct. * All artifacts have been deployed to the maven central repository. * Website pull request looks good.
Best, Hequn On Fri, Nov 22, 2019 at 8:18 PM Chesnay Schepler <ches...@apache.org> wrote: > +1 (binding) > > On 21/11/2019 14:08, Ufuk Celebi wrote: > > +1 (binding) > > > > * built master against flink-shaded 9.0 and jackson 2.10.1 (via > > https://repository.apache.org/content/repositories/orgapacheflink-1275) > > - code: https://github.com/uce/flink/tree/flink-shaded-9.0 > > - travis: https://travis-ci.org/uce/flink/builds/615013399 > > * ran examples against web UI and JSON requests/responses look good to me > > * Jira changelog looks good to me > > * website PR looks good to me > > * verified checksum: > > flink-shaded-9.0-src.tgz: OK > > * verified signature: > > gpg: Good signature from "Chesnay Schepler (CODE SIGNING KEY) < > > ches...@apache.org>" [unknown] > > gpg: WARNING: This key is not certified with a trusted signature! > > > > On Thu, Nov 21, 2019 at 10:46 AM Jingsong Li <jingsongl...@gmail.com> > wrote: > >> +1 (non-binding) > >> > >> - verified the signature and checksum > >> - checked the maven central artifices > >> - checked "release-9.0-rc1" source code > >> - verified website pull request listing the new release > >> > >> Best, > >> Jingsong Lee > >> > >> On Thu, Nov 21, 2019 at 5:28 PM Dian Fu <dian0511...@gmail.com> wrote: > >> > >>> +1 (non-binding) > >>> > >>> - verified the signature and checksum > >>> - checked the maven central artifices > >>> > >>> Regards, > >>> Dian > >>> > >>> > >>> > >>> On Wed, Nov 20, 2019 at 8:47 PM tison <wander4...@gmail.com> wrote: > >>> > >>>> +1 (non-binding) > >>>> > >>>> Best, > >>>> tison. > >>>> > >>>> > >>>> Aljoscha Krettek <aljos...@apache.org> 于2019年11月20日周三 下午6:58写道： > >>>> > >>>>> +1 (binding) > >>>>> > >>>>> Best, > >>>>> Aljoscha > >>>>> > >>>>>> On 19. Nov 2019, at 23:13, Chesnay Schepler <ches...@apache.org> > >>>> wrote: > >>>>>> Hi everyone, > >>>>>> Please review and vote on the release candidate #1 for the version > >>> 9.0, > >>>>> as follows: > >>>>>> [ ] +1, Approve the release > >>>>>> [ ] -1, Do not approve the release (please provide specific > > comments) > >>>>>> > >>>>>> The complete staging area is available for your review, which > >>> includes: > >>>>>> * JIRA release notes [1], > >>>>>> * the official Apache source release to be deployed to > >>> dist.apache.org > >>>>> [2], which are signed with the key with fingerprint 11D464BA [3], > >>>>>> * all artifacts to be deployed to the Maven Central Repository > > [4], > >>>>>> * source code tag "release-9.0-rc1" [5], > >>>>>> * website pull request listing the new release [6]. > >>>>>> > >>>>>> The vote will be open for at least 72 hours. It is adopted by > >>> majority > >>>>> approval, with at least 3 PMC affirmative votes. > >>>>>> Thanks, > >>>>>> Chesnay > >>>>>> > >>>>>> [1] > > https://issues.apache.org/jira/projects/FLINK/versions/12346089 > >>>>>> [2] > >>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-9.0-rc1/ > >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>>>> [4] > > https://repository.apache.org/content/repositories/orgapacheflink-1275 > >>>>>> [5] https://github.com/apache/flink-shaded/tree/release-9.0-rc1 > >>>>>> [6] https://github.com/apache/flink-web/pull/283 > >>>>>> > >>>>> > >> > >> -- > >> Best, Jingsong Lee > > >
