+1 (non-binding). This is really helpful, thanks Jingsong for driving this.
Zhenghua Gao <doc...@gmail.com> 于2020年2月10日周一 上午9:47写道: > +1 (non-binding). Thanks for driving this. > > *Best Regards,* > *Zhenghua Gao* > > > On Fri, Feb 7, 2020 at 5:05 PM Leonard Xu <xbjt...@gmail.com> wrote: > > > +1(non-binding), nice design! > > after read full discussion mail list. > > > > Best, > > Leonard Xu > > > > > 在 2020年2月6日,23:12,Timo Walther <twal...@apache.org> 写道: > > > > > > +1 > > > > > > On 06.02.20 05:54, Bowen Li wrote: > > >> +1, LGTM > > >> On Tue, Feb 4, 2020 at 11:28 PM Jark Wu <imj...@gmail.com> wrote: > > >>> +1 form my side. > > >>> Thanks for driving this. > > >>> > > >>> Btw, could you also attach a JIRA issue with the changes described in > > it, > > >>> so that users can find the issue through the mailing list in the > > future. > > >>> > > >>> Best, > > >>> Jark > > >>> > > >>> On Wed, 5 Feb 2020 at 13:38, Kurt Young <k...@apache.org> wrote: > > >>> > > >>>> +1 from my side. > > >>>> > > >>>> Best, > > >>>> Kurt > > >>>> > > >>>> > > >>>> On Wed, Feb 5, 2020 at 10:59 AM Jingsong Li <jingsongl...@gmail.com > > > > >>>> wrote: > > >>>> > > >>>>> Hi all, > > >>>>> > > >>>>> Interface updated. > > >>>>> Please re-vote. > > >>>>> > > >>>>> Best, > > >>>>> Jingsong Lee > > >>>>> > > >>>>> On Tue, Feb 4, 2020 at 1:28 PM Jingsong Li <jingsongl...@gmail.com > > > > >>>> wrote: > > >>>>> > > >>>>>> Hi all, > > >>>>>> > > >>>>>> I would like to start the vote for the improve of > > >>>>>> TableFactory, which is discussed and > > >>>>>> reached a consensus in the discussion thread[2]. > > >>>>>> > > >>>>>> The vote will be open for at least 72 hours. I'll try to close it > > >>>>>> unless there is an objection or not enough votes. > > >>>>>> > > >>>>>> [1] > > >>>>>> > > >>>>> > > >>>> > > >>> > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Improve-TableFactory-td36647.html > > >>>>>> > > >>>>>> Best, > > >>>>>> Jingsong Lee > > >>>>>> > > >>>>> > > >>>>> > > >>>>> -- > > >>>>> Best, Jingsong Lee > > >>>>> > > >>>> > > >>> > > > > > > > > -- Benchao Li School of Electronics Engineering and Computer Science, Peking University Tel:+86-15650713730 Email: libenc...@gmail.com; libenc...@pku.edu.cn