Hi Dawid, Thanks for driving this feature. The design looks very well for me overall.
I have only one concern: $ is not allowed to be used in the identifier of Python and so we have to come out with another symbol when aligning this feature in the Python Table API. I noticed that there are also other options proposed in the discussion thread, e.g. ref, col, etc. I think it would be great if the proposed symbol could be supported in both the Java/Scala and Python Table API. What's your thoughts? Regards, Dian > 在 2020年2月11日，上午11:13，Jark Wu <imj...@gmail.com> 写道： > > +1 for this. > > I have some minor comments: > - I'm +1 to use $ in both Java and Scala API. > - I'm +1 to use lit(), Spark also provides lit() function to create a > literal value. > - Is it possible to have `isGreater` instead of `isGreaterThan` and > `isGreaterOrEqual` instead of `isGreaterThanOrEqualTo` in BaseExpressions? > > Best, > Jark > > On Tue, 11 Feb 2020 at 10:21, Jingsong Li <jingsongl...@gmail.com> wrote: > >> Hi Dawid, >> >> Thanks for driving. >> >> - adding $ in scala api looks good to me. >> - Just a question, what should be expected to java.lang.Object? literal >> object or expression? So the Object is the grammatical sugar of literal? >> >> Best, >> Jingsong Lee >> >> On Mon, Feb 10, 2020 at 9:40 PM Timo Walther <twal...@apache.org> wrote: >> >>> +1 for this. >>> >>> It will also help in making a TableEnvironment.fromElements() possible >>> and reduces technical debt. One entry point of TypeInformation less in >>> the API. >>> >>> Regards, >>> Timo >>> >>> >>> On 10.02.20 08:31, Dawid Wysakowicz wrote: >>>> Hi all, >>>> >>>> I wanted to resurrect the thread about introducing a Java Expression >>>> DSL. Please see the updated flip page[1]. Most of the flip was >> concluded >>>> in previous discussion thread. The major changes since then are: >>>> >>>> * accepting java.lang.Object in the Java DSL >>>> >>>> * adding $ interpolation for a column in the Scala DSL >>>> >>>> I think it's important to move those changes forward as it makes it >>>> easier to transition to the new type system (Java parser supports only >>>> the old type system stack for now) that we are working on for the past >>>> releases. >>>> >>>> Because the previous discussion thread was rather conclusive I want to >>>> start already with a vote. If you think we need another round of >>>> discussion, feel free to say so. >>>> >>>> >>>> The vote will last for at least 72 hours, following the consensus >> voting >>>> process. >>>> >>>> FLIP wiki: >>>> >>>> [1] >>>> >>> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-55%3A+Introduction+of+a+Table+API+Java+Expression+DSL >>>> >>>> >>>> Discussion thread: >>>> >>>> >>> >> https://lists.apache.org/thread.html/eb5e7b0579e5f1da1e9bf1ab4e4b86dba737946f0261d94d8c30521e@%3Cdev.flink.apache.org%3E >>>> >>>> >>>> >>>> >>> >>> >> >> -- >> Best, Jingsong Lee >>
