LGTM now, +1 from my side. Best, Kurt
On Wed, Mar 4, 2020 at 12:27 AM Gary Yao <g...@apache.org> wrote: > Hi Yadong, > > Thank you for updating the wiki page. > > Only one minor suggestion – I would change: > > > If show-history is true return the information of attempt. > > to > > > If show-history is true, information for all attempts including > previous ones will be returned > > That being said, FLIP-100 looks good to me. From my side there is not > anything > else to discuss. > > @Kurt and @Jark: Can you look into the improvements that have been made > since > the last time you looked at the PoC? If you are happy, we can restart the > voting. > > Best, > Gary > > On Tue, Mar 3, 2020 at 2:34 PM Yadong Xie <vthink...@gmail.com> wrote: > >> Hi all >> >> The rest API part has been updated with Gary and Till's suggestions >> here is the link: >> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-100%3A+Add+Attempt+Information >> >> Yadong Xie <vthink...@gmail.com> 于2020年3月3日周二 下午9:14写道： >> >> > Hi Chesnay >> > >> > most discussions in this vote are about the more feature/demo request in >> > POC or discussion about response format, the main proposal the web UI >> part >> > which is not changed >> > >> > and the discussion about the response is converging, the response format >> > discussion could happen either here or at the code review stage, which >> > would be a minor change from my point of view. >> > >> > Chesnay Schepler <ches...@apache.org> 于2020年3月3日周二 下午8:20写道： >> > >> >> I suggest to cancel this vote. >> >> Several discussion items have been brought up during the vote, some of >> >> which are still unresolved, others which resulted in changes to the >> >> proposal. >> >> >> >> My conclusion is that this proposal needs more discussions. >> >> >> >> >> >> On 20/02/2020 10:46, Yadong Xie wrote: >> >> > Hi all >> >> > >> >> > I want to start the vote for FLIP-100, which proposes to add attempt >> >> > information inside subtask and timeline in web UI. >> >> > >> >> > To help everyone better understand the proposal, we spent some >> efforts >> >> on >> >> > making an online POC >> >> > >> >> > Timeline Attempt (click the vertex timeline to see the differences): >> >> > previous web: >> >> > >> >> >> http://101.132.122.69:8081/#/job/9d651769488466d33e7a607e85203543/timeline >> >> > POC web: >> >> > >> >> >> http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/timeline >> >> > >> >> > Subtask Attempt (click the vertex and switch to subtask tab to see >> the >> >> > differences): >> >> > previous web: >> >> > >> >> >> http://101.132.122.69:8081/#/job/9d651769488466d33e7a607e85203543/overview >> >> > POC web: >> >> > >> >> >> http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/overview >> >> > >> >> > >> >> > The vote will last for at least 72 hours, following the consensus >> voting >> >> > process. >> >> > >> >> > FLIP wiki: >> >> > >> >> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-100%3A+Add+Attempt+Information >> >> > >> >> > Discussion thread: >> >> > >> >> >> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-75-Flink-Web-UI-Improvement-Proposal-td33540.html >> >> > >> >> > Thanks, >> >> > >> >> > Yadong >> >> > >> >> >> >> >> >
