Hi, I think core of the jira right now is to investigate if catalogs of schemaless systems like HBase and Elasticsearch bring practical value to users. I haven't used these SQL connectors before, and thus don't have much to say in this case. Can anyone describe how it would work? Maybe @Yu or @Zheng can chime in.
w.r.t unsupported operation exception, they should be thrown in targeted getters (e.g. getView(), getFunction()). General listing APIs like listView(), listFunction() should not throw them but just return empty results, for the sake of not breaking user SQL experience. To dedup code, such common implementations can be moved to AbstractCatalog to make APIs look cleaner. I recall that there was an intention to refactor catalog API signatures, but haven't kept up with it. Bowen On Sun, Mar 15, 2020 at 10:19 PM Jingsong Li <jingsongl...@gmail.com> wrote: > Thanks Flavio for driving. Personally I am +1 for integrating HBase tables. > > I start a new topic for discussion. It is related but not the core of this > FLIP. > In the FLIP, I can see: > - Does HBase support the concept of partitions..? I don't think so.. > - Does HBase support functions? I don't think so.. > - Does HBase support statistics? I don't think so.. > - Does HBase support views? I don't think so.. > > And in JDBC catalog [1]. There are lots of UnsupportedOperationExceptions > too. > And maybe for confluent catalog, UnsupportedOperationExceptions come again. > Lots of UnsupportedOperationExceptions looks unhappy to this catalog api... > So can we do some refactor to catalog api? I can see a lot of catalogs > just need provide table information without partitions, functions, > statistics, views... > > CC: @Dawid Wysakowicz <dwysakow...@apache.org> @Bowen Li > <bowenl...@gmail.com> > > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-93%3A+JDBC+catalog+and+Postgres+catalog > > Best, > Jingsong Lee > > On Sat, Mar 14, 2020 at 7:36 AM Flavio Pompermaier <pomperma...@okkam.it> > wrote: > >> Hello everybody, >> I started a new FLIP to discuss about an HBaseCatalog implementation[1] >> after the opening of the relative issue by Bowen [2]. >> I drafted a very simple version of the FLIP just to discuss about the >> critical points (in red) in order to decide how to proceed. >> >> Best, >> Flavio >> >> [1] >> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-117%3A+HBase+catalog >> [2] https://issues.apache.org/jira/browse/FLINK-16575 >> > > > -- > Best, Jingsong Lee >
