+1  (non-binding)

maybe there is something that needs to be updated in README.md(currently
the official docs link points to the master instead of 2.1)

and have another question: do we need to add the command used to build the
base image locally(which was on the README.md in release-2.0.0)?

checked
- sha & gpg, ok
- mvn clean install -Prun-e2e-test on 1.8.0_252, ok
- source archives do not contains any binaries
- maven clean install -Papache-release, ok (this step need a gpg secret key)
- check all pom files, dockerfiles, examples point to the same version, ok
- check READM.md, nothing unexpected.
    - but the official docs link points to the master instead of 2.1
- run greeter&ride-share demo, ok

Best,
Congxian


Tzu-Li (Gordon) Tai <tzuli...@apache.org> 于2020年6月1日周一 下午3:25写道:

> Hi everyone,
>
> Please review and vote on the *release candidate #1* for the version 2.1.0
> of
> Apache Flink Stateful Functions,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> ***Testing Guideline***
>
> You can find here [1] a page in the project wiki on instructions for
> testing.
> To cast a vote, it is not necessary to perform all listed checks,
> but please mention which checks you have performed when voting.
>
> ***Release Overview***
>
> As an overview, the release consists of the following:
> a) Stateful Functions canonical source distribution, to be deployed to the
> release repository at dist.apache.org
> b) Stateful Functions Python SDK distributions to be deployed to PyPI
> c) Maven artifacts to be deployed to the Maven Central Repository
>
> ***Staging Areas to Review***
>
> The staging areas containing the above mentioned artifacts are as follows,
> for your review:
> * All artifacts for a) and b) can be found in the corresponding dev
> repository at dist.apache.org [2]
> * All artifacts for c) can be found at the Apache Nexus Repository [3]
>
> All artifacts are singed with the
> key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
>
> Other links for your review:
> * JIRA release notes [5]
> * source code tag "release-2.1.0-rc1" [6] [7]
>
> ***Vote Duration***
>
> The vote will be open for at least 72 hours *(target end date is Wednesday,
> Jun. 3rd).*
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Gordon
>
> [1]
>
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Stateful+Functions+Release
> [2] https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.1.0-rc1/
> [3]
> https://repository.apache.org/content/repositories/orgapacheflink-1373/
> [4] https://dist.apache.org/repos/dist/release/flink/KEYS
> [5]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12347861
> [6]
>
> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=tag;h=a372c69501b8816609f9e90872b1a1e10ab66e8e
> [7] https://github.com/apache/flink-statefun/tree/release-2.1.0-rc1
>

Reply via email to