+1 My only suggestion (although by no means a blocker) would be to remove from the FLIP the `env.setRuntimeMode()` method. I say that because this is syntactic sugar over the `env.configure()` with the `execution.runtime-mode` option set to BATCH or STREAMING. These methods can be nice but they seem to pile up and "pollute" our user-facing classes. In addition, later on we say that if the user wants to customize the execution by specifying for example the shuffle-mode, he/she can only do it through the configuration options.
Apart from that, I agree with the rest of the proposals. Kostas On Wed, Sep 16, 2020 at 11:27 AM David Anderson <da...@alpinegizmo.com> wrote: > > +1 > > Thanks for the discussion. Looking forward to seeing this all come to pass! > > David > > On Wed, Sep 16, 2020 at 9:28 AM Guowei Ma <guowei....@gmail.com> wrote: > > > +1 (non-binding) > > > > Best, > > Guowei > > > > > > On Wed, Sep 16, 2020 at 3:03 PM Yun Gao <yungao...@aliyun.com.invalid> > > wrote: > > > > > +1 (non-binding) > > > > > > Very thanks for bring this up! And the FLIP is indeed necessary for > > stream > > > & batch unification. > > > > > > ------------------------------------------------------------------ > > > Sender:Dawid Wysakowicz<dwysakow...@apache.org> > > > Date:2020/09/16 15:01:08 > > > Recipient:<dev@flink.apache.org>; Aljoscha Krettek<aljos...@apache.org> > > > Theme:Re: [VOTE] FLIP-134: Batch execution for the DataStream API > > > > > > +1 (binding) > > > > > > On 14/09/2020 14:25, Aljoscha Krettek wrote: > > > > > > > > Hi all, > > > > > > > > After the discussion in [1], I would like to open a voting thread for > > > > FLIP-134 (https://s.apache.org/FLIP-134) [2] which discusses a new > > > > BATCH execution mode for the DataStream API. > > > > > > > > The vote will be open until September 17, unless there is an objection > > > > or not enough votes. > > > > > > > > Regards, > > > > Aljoscha > > > > > > > > [1] > > > > > > > > > https://lists.apache.org/thread.html/reb368f095ec13638b95cd5d885a0aa8e69af06d6e982a5f045f50022%40%3Cdev.flink.apache.org%3E > > > > [2] https://cwiki.apache.org/confluence/x/4i94CQ > > > > > > > > > > >
