I agree that we can remove the double registered metrics. Maybe we can make this part of the effort to change the connectors to conform to FLIP-33.
What do you think? Thanks, Jiangjie (Becket) Qin On Wed, Sep 16, 2020 at 3:58 PM Dawid Wysakowicz <[email protected]> wrote: > Hi, > > When answering a user question in ML[1] I spotted that when we forward > Kafka's metrics we use only the name of the metric[2]. I was wondering > if we should use both the metric name and group? I think it would make > it easier to track back a particular metric. > > Moreover we still register Kafka's metrics both in the dedicated group > "KafkaConsumer", as well as in the subtasks group.[3] Can we remove it now? > > Best, > > Dawid > > [1] > > https://lists.apache.org/thread.html/ra1ec6c227b7c03df313cab523b6bdf511242751de8bce7f68efb2a52%40%3Cuser.flink.apache.org%3E > > [2] > > https://github.com/apache/flink/blob/b43075b710b27830830b8d2074454c69659392f5/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java#L185 > > [3] > > https://github.com/apache/flink/blob/b43075b710b27830830b8d2074454c69659392f5/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java#L188 > > >
