+1 (binding) - We mainly checked the patch of FLINK-20663 [1] and confirmed there is no OutOfManagedMemory error anymore.
[1] https://issues.apache.org/jira/browse/FLINK-20663 Best, Kurt On Tue, Mar 2, 2021 at 12:41 PM Yu Li <car...@gmail.com> wrote: > +1 (binding) > > - Checked the diff between 1.12.1 and 1.12.2-rc2: OK ( > https://github.com/apache/flink/compare/release-1.12.1...release-1.12.2-rc2 > ) > - jackson version has been bumped to 2.10.5.1 through FLINK-21020 and all > NOTICE files updated correctly > - beanutils version has been bumped to 1.9.4 through FLINK-21123 and all > NOTICE files updated correctly > - testcontainer version has been bumped to 1.15.1 through FLINK-21277 and > no NOTICE files impact > - japicmp version has been bumped to 1.12.1 and no NOTICE files impact > - Checked release notes: OK > - Checked sums and signatures: OK > - Maven clean install from source: OK > - Checked the jars in the staging repo: OK > - Checked the website updates: OK (minor: corrected fix version of > FLINK-21515 <https://issues.apache.org/jira/browse/FLINK-21515> to make > sure the website PR consistent with release note) > > Note: there's a vulnerability suspicion against 1.12.2-rc2 reported in > user-zh mailing list [1] w/o enough evidence/information. Have asked the > reporter to do more testing to confirm and I don't think it's a blocker for > the release, but just a note here in case anyone has a different opinion. > > Thanks a lot for managing the new RC! > > Best Regards, > Yu > > [1] http://apache-flink.147419.n8.nabble.com/flink-1-12-2-rc2-td11023.html > > On Tue, 2 Mar 2021 at 01:51, Piotr Nowojski <pnowoj...@apache.org> wrote: > > > +1 (binding) > > > > For the RC2 I have additionally confirmed that "stop-with-savepoint", and > > "stop-with-savepoint --drain" seems to be working. > > > > Piotrek > > > > pon., 1 mar 2021 o 11:18 Matthias Pohl <matth...@ververica.com> > > napisał(a): > > > > > Thanks for managing release 1.12.2, Yuan & Roman. > > > > > > +1 (non-binding) > > > > > > - Verified checksums and GPG of artifacts in [1] > > > - Build the sources locally without errors > > > - Started a local standalone cluster and deployed WordCount without > > > problems (no suspicious logs identified) > > > - Verified FLINK-21030 [2] by running the example jobs from the > > > FLINK-21030-related SavepointITCase tests > > > > > > Best, > > > Matthias > > > > > > [1] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.2-rc2/ > > > [2] https://issues.apache.org/jira/browse/FLINK-21030 > > > > > > On Sun, Feb 28, 2021 at 2:41 PM Yuan Mei <yuanmei.w...@gmail.com> > wrote: > > > > > > > Hey Roman, > > > > > > > > Thank you very much for preparing RC2. > > > > > > > > +1 from my side. > > > > > > > > 1. Verified Checksums and GPG signatures. > > > > 2. Verified that the source archives do not contain any binaries. > > > > 3. Successfully Built the source with Maven. > > > > 4. Started a local Flink cluster, ran the streaming WordCount example > > > with > > > > WebUI, > > > > checked the output and JM/TM log, no suspicious output/log. > > > > 5. Repeat Step 4 with the binary release as well, no suspicious > > > output/log. > > > > 6. Checked for source and binary release to make sure both an Apache > > > > License file and a NOTICE file are included. > > > > 7. Manually verified that no pom file changes between 1.12.2-rc1 and > > > > 1.12.2-rc2; no obvious license problem. > > > > 8. Review the release PR for RC2 updates, and double confirmed the > > > > change-list for 1.12.2. > > > > > > > > Best, > > > > Yuan > > > > > > > > On Sat, Feb 27, 2021 at 7:19 AM Roman Khachatryan <ro...@apache.org> > > > > wrote: > > > > > > > > > Hi everyone, > > > > > > > > > > Please review and vote on the release candidate #1 for the version > > > > 1.12.2, > > > > > as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific > comments) > > > > > > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > * JIRA release notes [1], > > > > > * the official Apache source release and binary convenience > releases > > to > > > > be > > > > > deployed to dist.apache.org [2], which are signed with the key > with > > > > > fingerprint 0D545F264D2DFDEBFD4E038F97B4625E2FCF517C [3], > > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > > * source code tag "release-1.12.2-rc2" [5], > > > > > * website pull request listing the new release and adding > > announcement > > > > blog > > > > > post [6]. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349502&projectId=12315522 > > > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.2-rc2/ > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [4] > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1414/ > > > > > [5] > https://github.com/apache/flink/releases/tag/release-1.12.2-rc2 > > > > > [6] https://github.com/apache/flink-web/pull/418 > > > > > > > > > > Regards, > > > > > Roman > > > > > > > > > > >
