Thanks for voting and testing everyone! We have a total of 6 +1 votes, 3 of which are binding: - Igal Shilman - Gordon Tai (binding) - Konstantin Knauf - Seth Wiesman - Yu Li (binding) - Robert Metzger (binding)
I'll proceed now with finalizing the release of StateFun 3.0.0. The official announcement will likely happen next week, as we're finishing up with the announcement blog post which would probably also take a few days to be reviewed. Thanks, Gordon On Thu, Apr 8, 2021 at 1:50 PM Robert Metzger <rmetz...@apache.org> wrote: > I see. Thanks a lot for clarifying. > > I then vote > > +1 (binding) > > on this release. Thanks a lot for driving this! > > > On Thu, Apr 8, 2021 at 5:19 AM Tzu-Li (Gordon) Tai <tzuli...@apache.org> > wrote: > >> @Robert Metzger <rmetz...@apache.org> >> >> Sorry, this is the correct link to the class file you are referring to >> (previous link I mentioned is incorrect): >> >> https://github.com/apache/flink-statefun/blob/master/statefun-flink/statefun-flink-common/src/main/java/com/google/protobuf/MoreByteStrings.java >> >> On Thu, Apr 8, 2021 at 11:17 AM Tzu-Li (Gordon) Tai <tzuli...@apache.org> >> wrote: >> >>> @Robert Metzger <rmetz...@apache.org> >>> >>> I assume the com/google/protobuf classfile you found is this one: >>> >>> https://github.com/apache/flink-statefun/blob/master/statefun-shaded/statefun-protobuf-shaded/src/main/java/org/apache/flink/statefun/sdk/shaded/com/google/protobuf/MoreByteStrings.java >>> >>> This actually isn't a class pulled from a Protobuf dependency - it's >>> code developed under StateFun. >>> The package com/google/protobuf was required because the class exists >>> essentially as a workaround to access some package-private protected >>> methods on Protobuf. >>> >>> I believe that in this case, a NOTICE acknowledgement is not required as >>> we actually own that piece of code. >>> >>> Let me know what you think and if this clears things up! >>> >>> Cheers, >>> Gordon >>> >>> On Thu, Apr 8, 2021 at 4:00 AM Robert Metzger <rmetz...@apache.org> >>> wrote: >>> >>>> This jar contains a com/google/protobuf classfile, which is not >>>> declared in >>>> any NOTICE file (and doesn't ship the license file of protobuf): >>>> >>>> https://repository.apache.org/content/repositories/orgapacheflink-1415/org/apache/flink/statefun-flink-common/3.0.0/statefun-flink-common-3.0.0.jar >>>> >>>> I fear that this could be a blocker for the release? >>>> >>>> Otherwise, I did the following check: >>>> >>>> - src distribution looks fine: No binaries, js related files are >>>> declared >>>> (the copyright in the NOTICE file could be updated to 2021, but that's >>>> not >>>> a blocker) >>>> >>>> >>>> On Fri, Apr 2, 2021 at 8:29 AM Yu Li <car...@gmail.com> wrote: >>>> >>>> > +1 (binding) >>>> > >>>> > Checked sums and signatures: OK >>>> > Checked RAT and end-to-end tests: OK >>>> > Checked version in pom/README/setup.py files: OK >>>> > Checked release notes: OK >>>> > Checked docker PR: OK >>>> > >>>> > Thanks for driving this release, Gordon! >>>> > >>>> > Best Regards, >>>> > Yu >>>> > >>>> > >>>> > On Fri, 2 Apr 2021 at 09:22, Seth Wiesman <sjwies...@gmail.com> >>>> wrote: >>>> > >>>> > > +1 (non-binding) >>>> > > >>>> > > - Built from source and executed end to end tests >>>> > > - Checked licenses and signatures >>>> > > - Deployed remote Java SDK to gke cluster >>>> > > - Took savepoint and statefully rescaled >>>> > > >>>> > > Seth >>>> > > >>>> > > On Thu, Apr 1, 2021 at 9:05 AM Konstantin Knauf <kna...@apache.org> >>>> > wrote: >>>> > > >>>> > > > +1 (non-binding) >>>> > > > >>>> > > > - mvn clean install -Prun-e2e-tests (java 8) from source >>>> > > > - python3 -m unittest tests >>>> > > > - spin up Statefun Cluster on EKS with an image built from the >>>> > > Dockerfiles >>>> > > > of [1] >>>> > > > - run Python & Java Greeter example on AWS Lambda >>>> > > > - read through documentation (opened [2] to fix some tpoys) >>>> > > > >>>> > > > [1] https://github.com/apache/flink-statefun-docker/pull/13 >>>> > > > [2] https://github.com/apache/flink-statefun/pull/219 >>>> > > > >>>> > > > On Thu, Apr 1, 2021 at 6:46 AM Tzu-Li (Gordon) Tai < >>>> > tzuli...@apache.org> >>>> > > > wrote: >>>> > > > >>>> > > > > +1 (binding) >>>> > > > > >>>> > > > > - verified signatures and hashes >>>> > > > > - NOTICE and LICENSE files in statefun-flink-distribution, >>>> > > > > statefun-protobuf-shaded, and statefun-sdk-java looks sane >>>> > > > > - maven clean install -Prun-e2e-tests (java 8) from source >>>> > > > > - ran all examples and tutorials in >>>> apache/flink-statefun-playground >>>> > > with >>>> > > > > the new artifacts >>>> > > > > - Ran my SDK verifier utility [1] against the new Java and >>>> Python >>>> > SDKs. >>>> > > > > >>>> > > > > Cheers, >>>> > > > > Gordon >>>> > > > > >>>> > > > > [1] https://github.com/tzulitai/statefun-sdk-verifier >>>> > > > > >>>> > > > > On Wed, Mar 31, 2021 at 8:50 PM Igal Shilman < >>>> i...@ververica.com> >>>> > > wrote: >>>> > > > > >>>> > > > > > Thanks Gordon for managing the release! >>>> > > > > > >>>> > > > > > +1 (non binding) from my side: >>>> > > > > > >>>> > > > > > Here are the results of my testing: >>>> > > > > > - verified the signatures >>>> > > > > > - verified that the source distribution doesn't contain any >>>> binary >>>> > > > files >>>> > > > > > - ran mvn clean install -Prun-e2e-tests with java8 >>>> > > > > > - ran the smoke test that sends 100 million messages locally. >>>> > > > > > - extended the smoke test to include the remote sdks (1 >>>> function in >>>> > > the >>>> > > > > > Java SDK, 1 function in the Python SDK), and it passes. >>>> > > > > > - deployed to kubernetes with minio as an S3 replacement. >>>> > > > > > >>>> > > > > > >>>> > > > > > On Tue, Mar 30, 2021 at 12:29 PM Tzu-Li (Gordon) Tai < >>>> > > > > tzuli...@apache.org> >>>> > > > > > wrote: >>>> > > > > > >>>> > > > > > > Hi everyone, >>>> > > > > > > >>>> > > > > > > Please review and vote on the release candidate #1 for the >>>> > version >>>> > > > > 3.0.0 >>>> > > > > > of >>>> > > > > > > Apache Flink Stateful Functions, as follows: >>>> > > > > > > [ ] +1, Approve the release >>>> > > > > > > [ ] -1, Do not approve the release (please provide specific >>>> > > comments) >>>> > > > > > > >>>> > > > > > > **Testing Guideline** >>>> > > > > > > >>>> > > > > > > You can find here [1] a page in the project wiki on >>>> instructions >>>> > > for >>>> > > > > > > testing. >>>> > > > > > > To cast a vote, it is not necessary to perform all listed >>>> checks, >>>> > > > > > > but please mention which checks you have performed when >>>> voting. >>>> > > > > > > >>>> > > > > > > **Release Overview** >>>> > > > > > > >>>> > > > > > > As an overview, the release consists of the following: >>>> > > > > > > a) Stateful Functions canonical source distribution, to be >>>> > deployed >>>> > > > to >>>> > > > > > the >>>> > > > > > > release repository at dist.apache.org >>>> > > > > > > b) Stateful Functions Python SDK distributions to be >>>> deployed to >>>> > > PyPI >>>> > > > > > > c) Maven artifacts to be deployed to the Maven Central >>>> Repository >>>> > > > > > > d) New Dockerfiles for the release >>>> > > > > > > >>>> > > > > > > **Staging Areas to Review** >>>> > > > > > > >>>> > > > > > > The staging areas containing the above mentioned artifacts >>>> are as >>>> > > > > > follows, >>>> > > > > > > for your review: >>>> > > > > > > * All artifacts for a) and b) can be found in the >>>> corresponding >>>> > dev >>>> > > > > > > repository at dist.apache.org [2] >>>> > > > > > > * All artifacts for c) can be found at the Apache Nexus >>>> > Repository >>>> > > > [3] >>>> > > > > > > >>>> > > > > > > All artifacts are signed with the key >>>> > > > > > > 1C1E2394D3194E1944613488F320986D35C33D6A [4] >>>> > > > > > > >>>> > > > > > > Other links for your review: >>>> > > > > > > * JIRA release notes [5] >>>> > > > > > > * source code tag “release-3.0.0-rc1” [6] >>>> > > > > > > * PR for the new Dockerfiles [7] >>>> > > > > > > >>>> > > > > > > **Vote Duration** >>>> > > > > > > >>>> > > > > > > The voting time will run for at least 72 hours. I’m >>>> targeting >>>> > this >>>> > > > vote >>>> > > > > > to >>>> > > > > > > last until April. 2nd, 12pm CET. >>>> > > > > > > It is adopted by majority approval, with at least 3 PMC >>>> > affirmative >>>> > > > > > votes. >>>> > > > > > > >>>> > > > > > > Thanks, >>>> > > > > > > Gordon >>>> > > > > > > >>>> > > > > > > [1] >>>> > > > > > > >>>> > > > > > > >>>> > > > > > >>>> > > > > >>>> > > > >>>> > > >>>> > >>>> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Stateful+Functions+Release >>>> > > > > > > [2] >>>> > > > > > >>>> > > >>>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-3.0.0-rc1/ >>>> > > > > > > [3] >>>> > > > > > > >>>> > > > > >>>> > > >>>> https://repository.apache.org/content/repositories/orgapacheflink-1415/ >>>> > > > > > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS >>>> > > > > > > [5] >>>> > > > > > > >>>> > > > > > > >>>> > > > > > >>>> > > > > >>>> > > > >>>> > > >>>> > >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12348822 >>>> > > > > > > [6] >>>> > > https://github.com/apache/flink-statefun/tree/release-3.0.0-rc1 >>>> > > > > > > [7] https://github.com/apache/flink-statefun-docker/pull/13 >>>> > > > > > > >>>> > > > > > >>>> > > > > >>>> > > > >>>> > > > >>>> > > > -- >>>> > > > >>>> > > > Konstantin Knauf >>>> > > > >>>> > > > https://twitter.com/snntrable >>>> > > > >>>> > > > https://github.com/knaufk >>>> > > > >>>> > > >>>> > >>>> >>>
