Hi Becket, Thanks for taking a look at the FLIP page.
I just updated it to include the classes that are user facing, i.e. those that a user would interact with when using the HybridSource. I also updated the examples in the HybridSource code block to show both of the scenarios, fixed start position and construction of source at time of switch. Please let me know if you have other questions. We could also need few more binding votes: https://lists.apache.org/thread.html/rb900fcfa4ffb81fe58efde489568b1e5cc3a02d16665679545a534c7%40%3Cdev.flink.apache.org%3E Thanks, Thomas On Tue, Jul 6, 2021 at 1:18 AM Becket Qin <becket....@gmail.com> wrote: > Hi Nicholas and Thomas, > > Thanks for pushing this FLIP. The hybrid source is quite useful. It seems > that the FLIP wiki page did not cover all the new public interfaces we are > introducing. For example, the interface of the following classes are either > incomplete or not included in the wiki at the point. > > HybridSourceSplit > HybridSourceEnumeratorState > SourceFactory > HybridSourceBuilder > > As far as I understand these are public APIs that are visible to the users. > Not sure if they are all the public interfaces, though. Can you please > update the FLIP to make the public interface change clear and complete? > > Thanks, > > Jiangjie (Becket) Qin > > > On Tue, Jul 6, 2021 at 4:11 PM 蒋晓峰 <programg...@163.com> wrote: > > > Hello everyone, > > > > > > Sorry for the mistake to report the result of FLIP-150 voting for only > > 2 binding. Please ignore the vote result for FLIP-150. The vote of > FLIP-150 > > is still open, please continue to vote FLIP-150: Introduce Hybrid Source. > > > > > > Thanks, > > Nicholas Jiang >
