Hi everyone, if the HybridSource is self contained, then I don't see a lot of harm in doing the backport. We should probably explicitly state in the docs that a certain minor version is required for this source to be available because our docs don't distinguish between minor versions and having to use a specific minor version for a feature might be confusing.
Speaking of which, I would actually prefer it if we first completed the pending documentation and e2e test task because I believe they are more important than the backport. W/o documentation, the HybridSource is effectively non-existent. Also if the e2e test adds better test coverage, then we probably should wait a bit with the backport. Cheers, Till On Thu, Aug 19, 2021 at 6:54 PM Thomas Weise <t...@apache.org> wrote: > PR: https://github.com/apache/flink/pull/16899 > > > On Mon, Aug 16, 2021 at 3:49 PM Thomas Weise <t...@apache.org> wrote: > > > Hi Arvid, > > > > I would not recommend to mix minor Flink versions: > > > > 1. As you said, 1.14 isn't released yet and most users would prefer > > to not depend on snapshots > > 2. There could be unrelated changes between 1.13 and 1.14 that make the > > use of 1.14 artifact with 1.13 impossible or lead to unforeseen side > > effects due to transitive dependencies > > > > Thanks, > > Thomas > > > > On Mon, Aug 16, 2021 at 12:07 PM Arvid Heise <ar...@apache.org> wrote: > > > >> Hi Thomas, > >> > >> that's neat. I forgot for a moment that connector-base is not part of > >> flink-dist. > >> > >> I guess in theory, we could also omit the backport and simply refer > users > >> to 1.14 version. I'm assuming you want to have it in 1.13 since 1.14 > still > >> takes a bit. Am I correct? > >> > >> On Mon, Aug 16, 2021 at 7:43 PM Thomas Weise <t...@apache.org> wrote: > >> > >> > Hi Arvid, > >> > > >> > Thank you for the reply. Can you please explain a bit more > >> > your concern regarding an earlier bugfix level? > >> > > >> > I should have maybe made clear that the HybridSource can be used by > >> > updating flink-connector-base in the application jar. It does not > >> require > >> > any addition to the runtime and therefore would work on any 1.13.x > dist. > >> > > >> > For reference, I use it internally on top of 1.12.4. > >> > > >> > Thanks, > >> > Thomas > >> > > >> > > >> > On Mon, Aug 16, 2021 at 10:13 AM Arvid Heise <ar...@apache.org> > wrote: > >> > > >> > > Hi Thomas, > >> > > > >> > > since the change didn't modify any existing classes, I'm weakly in > >> favor > >> > of > >> > > backporting. My reluctance mainly stems from possible > disappointments > >> > from > >> > > 1.13 users that use an earlier bugfix level. So we need to make > >> > > documentation clear. > >> > > > >> > > In general, I'm seeing connectors as something extra (and plan to > make > >> > that > >> > > more transparent), so I think we have more freedom for backports > >> there in > >> > > contrast to other components. But it would be good to hear other > >> opinions > >> > > on that matter. > >> > > > >> > > On Mon, Aug 16, 2021 at 5:26 PM Thomas Weise <t...@apache.org> > wrote: > >> > > > >> > > > Hi, > >> > > > > >> > > > HybridSource [1] [2] was recently merged to the main branch. I > would > >> > like > >> > > > to propose to backport it to release-1.13. Although it is a new > >> > feature, > >> > > it > >> > > > is also strictly additive and does not affect any existing code. > The > >> > > > benefit is that we will have a released runtime version that the > >> > feature > >> > > > can be used with for those that are interested in it and dependent > >> on a > >> > > > distribution they cannot modify. > >> > > > > >> > > > Are there any concerns backporting the change? > >> > > > > >> > > > Thanks, > >> > > > Thomas > >> > > > > >> > > > [1] https://issues.apache.org/jira/browse/FLINK-22670 > >> > > > [2] https://github.com/apache/flink/pull/15924 > >> > > > > >> > > > >> > > >> > > >
