+1 to merge this PR for 1.14 release. This is a widely used and stable feature, so it would be nice to be enabled by default.
Best, Jark On Tue, 24 Aug 2021 at 17:02, Jingsong Li <[email protected]> wrote: > Hi everyone, > > Details about FLINK-23755: > > Before this JIRA, the below SQL will throw an exception: > "SELECT * FROM kafka_table /*+ OPTIONS('group.id'='new_id') */". > > Before, we introduced the feature of dynamic table options, but in > order to avoid user abuse, we turned it off by default, so the above > SQL will throw exceptions. > > When modifying the value of table.dynamic-table-options.enabled to > true, the SQL can work. > > After so many versions, we think this feature can be provided to > users, and it is also relied on by many users, so we open it by > default. > > Best, > Jingsong > > On Tue, Aug 24, 2021 at 4:48 PM Jingsong Li <[email protected]> > wrote: > > > > Hi all, > > > > Since Flink 1.14 is already code freeze, we'd like to merge > > FLINK-23755 [1]. PR is [2] > > > > We think FLINK-23755 is not a new feature, but it is a behavior > > changer and an usability improvement. It's disappointing to wait for > > one more release for users. > > > > What do you think? > > > > [1]https://issues.apache.org/jira/browse/FLINK-23755 > > [2]https://github.com/apache/flink/pull/16887 > > > > Best, > > Jingsong > > > > -- > Best, Jingsong Lee >
