I'm also in favour of "flink-table-store".

Best,
Jark

On Mon, 10 Jan 2022 at 16:18, David Morávek <d...@apache.org> wrote:

> Hi Jingsong,
>
> the connector repository prototype I've seen is being built on top of
> Gradle [1], that's why I was referring to it (I think one idea was also to
> migrate the main repository to Gradle eventually). I think Martijn / Fabian
> may be bit more familiar with the connectors repository effort and could
> shed some light on this.
>
> [1] https://github.com/apache/flink-connectors
>
> Best,
> D.
>
> On Mon, Jan 10, 2022 at 8:57 AM Yu Li <car...@gmail.com> wrote:
>
> > +1 for a separate repository and release pipeline in the same way as
> > flink-statefun [1], flink-ml [2] and the coming flink-connectors [3].
> >
> > +1 for naming it as "flink-table-store" (I'm also ok with
> > "flink-table-storage", but slightly prefer "flink-table-store" because
> it's
> > shorter)
> >
> > Thanks for driving this Jingsong, and look forward to a fast evolution of
> > this direction!
> >
> > Best Regards,
> > Yu
> >
> > [1] https://github.com/apache/flink-statefun
> > [2] https://github.com/apache/flink-ml
> > [3] https://github.com/apache/flink-connectors
> >
> >
> > On Mon, 10 Jan 2022 at 10:52, Jingsong Li <jingsongl...@gmail.com>
> wrote:
> >
> > > Hi David, thanks for your suggestion.
> > >
> > > I think we should re-use as many common components with connectors as
> > > possible. I don't fully understand what you mean, but for this project
> > > I prefer to use Maven rather than Gradle.
> > >
> > > Best,
> > > Jingsong
> > >
> > > On Fri, Jan 7, 2022 at 11:59 PM David Morávek <d...@apache.org> wrote:
> > > >
> > > > +1 for the separate repository under the Flink umbrella
> > > >
> > > > as we've already started creating more repositories with connectors,
> > > would
> > > > it be possible to re-use the same build infrastructure for this one?
> > (eg.
> > > > shared set of Gradle plugins that unify the build experience)?
> > > >
> > > > Best,
> > > > D.
> > > >
> > > > On Fri, Jan 7, 2022 at 11:31 AM Jingsong Li <jingsongl...@gmail.com>
> > > wrote:
> > > >
> > > > > For more references on `store` and `storage`:
> > > > >
> > > > > For example,
> > > > >
> > > > > Rocksdb is a library that provides an embeddable, persistent
> > key-value
> > > > > store for fast storage. [1]
> > > > >
> > > > > Apache HBase [1] is an open-source, distributed, versioned,
> > > > > column-oriented store modeled after Google' Bigtable. [2]
> > > > >
> > > > > [1] https://github.com/facebook/rocksdb
> > > > > [2] https://github.com/apache/hbase
> > > > >
> > > > > Best,
> > > > > Jingsong
> > > > >
> > > > > On Fri, Jan 7, 2022 at 6:17 PM Jingsong Li <jingsongl...@gmail.com
> >
> > > wrote:
> > > > > >
> > > > > > Thanks all,
> > > > > >
> > > > > > Combining everyone's comments, I recommend using
> > `flink-table-store`:
> > > > > >
> > > > > > ## table
> > > > > > something to do with table storage (From Till). Not only
> > flink-table,
> > > > > > but also for user-oriented tables.
> > > > > >
> > > > > > ## store vs storage
> > > > > > - The first point I think, store is better pronounced, storage is
> > > > > > three syllables while store is two syllables
> > > > > > - Yes, store also stands for shopping. But I think the English
> > > > > > polysemy is also quite interesting, a store to store various
> items,
> > > it
> > > > > > also feels interesting to represent the feeling that we want to
> do
> > > > > > data storage.
> > > > > > - The first feeling is, storage is a physical object or abstract
> > > > > > concept, store is a software application or entity
> > > > > >
> > > > > > So I prefer `flink-table-store`, what do you think?
> > > > > >
> > > > > > (@_@ Naming is too difficult)
> > > > > >
> > > > > > Best,
> > > > > > Jingsong
> > > > > >
> > > > > > On Fri, Jan 7, 2022 at 5:37 PM Konstantin Knauf <
> kna...@apache.org
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > +1 to a separate repository assuming this repository will still
> > be
> > > > > part of
> > > > > > > Apache Flink (same PMC, Committers). I am not aware we have
> > > something
> > > > > like
> > > > > > > "sub-projects" officially.
> > > > > > >
> > > > > > > I share Till and Timo's concerns regarding "store".
> > > > > > >
> > > > > > > On Fri, Jan 7, 2022 at 9:59 AM Till Rohrmann <
> > trohrm...@apache.org
> > > >
> > > > > wrote:
> > > > > > >
> > > > > > > > +1 for the separate project.
> > > > > > > >
> > > > > > > > I would agree that flink-store is not the best name.
> > > flink-storage >
> > > > > > > > flink-store but I would even more prefer a name that conveys
> > > that it
> > > > > has
> > > > > > > > something to do with table storage.
> > > > > > > >
> > > > > > > > Cheers,
> > > > > > > > Till
> > > > > > > >
> > > > > > > > On Fri, Jan 7, 2022 at 9:14 AM Timo Walther <
> > twal...@apache.org>
> > > > > wrote:
> > > > > > > >
> > > > > > > > > +1 for the separate project
> > > > > > > > >
> > > > > > > > > But maybe use `flink-storage` instead of `flink-store`?
> > > > > > > > >
> > > > > > > > > I'm not a native speaker but store is defined as "A place
> > where
> > > > > items
> > > > > > > > > may be purchased.". It almost sounds like the
> > `flink-packages`
> > > > > project.
> > > > > > > > >
> > > > > > > > > Regards,
> > > > > > > > > Timo
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 07.01.22 08:37, Jingsong Li wrote:
> > > > > > > > > > Hi everyone,
> > > > > > > > > >
> > > > > > > > > > I'd like to start a vote for create a separate sub
> project
> > > for
> > > > > > > > > > FLIP-188 [1]: `flink-store`.
> > > > > > > > > >
> > > > > > > > > > - If you agree with the name `flink-store`, please just
> +1
> > > > > > > > > > - If you have a better suggestion, please write your
> > > suggestion,
> > > > > > > > > > followed by a reply that can +1 to the name that has
> > appeared
> > > > > > > > > > - If you do not want it to be a subproject of flink, just
> > -1
> > > > > > > > > >
> > > > > > > > > > The vote will be open for at least 72 hours unless there
> is
> > > an
> > > > > > > > > > objection or not enough votes.
> > > > > > > > > >
> > > > > > > > > > [1]
> > > > > > > > >
> > > > > > > >
> > > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-188%3A+Introduce+Built-in+Dynamic+Table+Storage
> > > > > > > > > >
> > > > > > > > > > Best,
> > > > > > > > > > Jingsong
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > >
> > > > > > > Konstantin Knauf
> > > > > > >
> > > > > > > https://twitter.com/snntrable
> > > > > > >
> > > > > > > https://github.com/knaufk
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best, Jingsong Lee
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best, Jingsong Lee
> > > > >
> > >
> > >
> > >
> > > --
> > > Best, Jingsong Lee
> > >
> >
>

Reply via email to