Hi Xintong, I have been contemplating the same for a while. The final docker image that will be uploaded to dockerhub should be the same image as the one on ghcr.io (re-tagged and reuploaded).
We made the decision to try to keep the integrity of the RC and the final release and not make any changes afterwards. I think it is fine to have the Helm chart point to ghcr.io image as it is also owned by the project. It also makes image verification easier during testing. It should be clear from the readme how to use the dockerhub image instead. If we see any problems with this in the future we could try to adapt your suggestion. Cheers, Gyula On Fri, Apr 1, 2022 at 9:51 AM Xintong Song <tonysong...@gmail.com> wrote: > I have a concern, which I'm not sure whether it should be a release > blocker. > > While trying to install the operator via helm, I noticed that the image is > pulled from `ghcr.io/apache/flink-kubernetes-operator` > <http://ghcr.io/apache/flink-kubernetes-operator>. IIUC, in one of the > previous voting threads it is mentioned that we are not using `ghcr.io` > for > the final release, but will use DockerHub instead. Then how are we going to > change from `ghcr.io` to `DockerHub` without modifying the staged release > candidate? Maybe we should point to the DockerHub image (which does not > exist yet) in `values.yaml` and overwrite it to the temporal `ghcr.io` > image only for verifying the release candidate? > > Thank you~ > > Xintong Song > > > > On Fri, Apr 1, 2022 at 1:02 PM Thomas Weise <t...@apache.org> wrote: > > > +1 (binding) > > > > * installed from staged helm chart and run example > > * built from source > > > > > > On Wed, Mar 30, 2022 at 7:39 AM Gyula Fóra <gyf...@apache.org> wrote: > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #3 for the version > 0.1.0 > > of > > > Apache Flink Kubernetes Operator, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > **Release Overview** > > > > > > As an overview, the release consists of the following: > > > a) Kubernetes Operator canonical source distribution (including the > > > Dockerfile), to be deployed to the release repository at > dist.apache.org > > > b) Kubernetes Operator Helm Chart to be deployed to the release > > repository > > > at dist.apache.org > > > c) Maven artifacts to be deployed to the Maven Central Repository > > > d) Docker image to be pushed to dockerhub > > > > > > **Staging Areas to Review** > > > > > > The staging areas containing the above mentioned artifacts are as > > follows, > > > for your review: > > > * All artifacts for a,b) can be found in the corresponding dev > repository > > > at dist.apache.org [1] > > > * All artifacts for c) can be found at the Apache Nexus Repository [2] > > > * The docker image is staged on github [7] > > > > > > All artifacts are signed with the key > > > 0B4A34ADDFFA2BB54EB720B221F06303B87DAFF1 [3] > > > > > > Other links for your review: > > > * JIRA release notes [4] > > > * source code tag "release-0.1.0-rc3" [5] > > > * PR to update the website Downloads page to include Kubernetes > Operator > > > links [6] > > > > > > **Vote Duration** > > > > > > The voting time will run for at least 72 hours. > > > It is adopted by majority approval, with at least 3 PMC affirmative > > votes. > > > > > > **Note on Verification** > > > > > > You can follow the basic verification guide here > > > < > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release > > > > > > > . > > > Note that you don't need to verify everything yourself, but please make > > > note of what you have tested together with your +- vote. > > > > > > Thanks, > > > Gyula > > > > > > [1] > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-0.1.0-rc3/ > > > [2] > > > > https://repository.apache.org/content/repositories/orgapacheflink-1492/ > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > [4] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351499 > > > [5] > > > > > > https://github.com/apache/flink-kubernetes-operator/tree/release-0.1.0-rc3 > > > [6] https://github.com/apache/flink-web/pull/519 > > > [7] ghcr.io/apache/flink-kubernetes-operator:2c166e3 > > > > > >
