Very thanks Dawid for the check! I think the issue of wrong licences should indeed be a blocker. I'll also have a look at these issues.
Due to the issues, the RC2 would be officially canceled and I'll create the RC3 after these issues are fixed. ------------------Original Mail ------------------ Sender:Chesnay Schepler <ches...@apache.org> Send Date:Thu Apr 14 00:40:32 2022 Recipients:Dev <dev@flink.apache.org>, Dawid Wysakowicz <dwysakow...@apache.org>, Yun Gao <yungao...@aliyun.com.INVALID> Subject:Re: [VOTE] Release 1.15.0, release candidate #2 Re why CI didn't pick up on it: Currently, excessive NOTICE entries don't fail CI, only missing ones do. They should be logged though! The reason being that only missing entries are problems (for us, in a legal sense). That would be easy to change though. On 13/04/2022 17:40, Dawid Wysakowicz wrote: > > -1, > > I checked new modules and modules with updated dependencies for proper > listing LICENSE files. I found a number of issues, of which one > justifies cancelling the rc, imo. > > Blocker: > > * https://issues.apache.org/jira/browse/FLINK-27231 > > Minor: > > * https://issues.apache.org/jira/browse/FLINK-27230 > * https://issues.apache.org/jira/browse/FLINK-27233 > > I checked the following modules: > > * flink-connector-kinesis > * flink-sql-connector-aws-kinesis-firehose > * flink-sql-connector-pulsar (blocker) > * flink-dist-scala_2.12 > * flink-sql-connector-rabbitmq > * flink-gs-fs-hadoop > * flink-sql-connector-elasticsearch7 > > Side note, shouldn't the two minor issues be automatically discovered > by the license checks on CI? > > Please let me know what you think about the blocker I found. > > Best, > > Dawid > > On 12/04/2022 17:09, Yun Gao wrote: >> Hi everyone, >> Please review and vote on the release candidate #2 for the version 1.15.0, >> as follows: >> [ ] +1, Approve the release >> [ ] -1, Do not approve the release (please provide specific comments) >> The complete staging area is available for your review, which includes: >> * JIRA release notes [1], >> * the official Apache source release and binary convenience releases to be >> deployed to dist.apache.org [2], which are signed with the key with >> fingerprint CBE82BEFD827B08AFA843977EDBF922A7BC84897 [3], >> * all artifacts to be deployed to the Maven Central Repository [4], >> * source code tag "release-1.15.0-rc2" [5], >> * website pull request listing the new release and adding announcement blog >> post [6]. >> The vote will be open for at least 72 hours. It is adopted by majority >> approval, with at least 3 PMC affirmative votes. >> Thanks, >> Joe, Till and Yun Gao >> [1]https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350442 >> [2]https://dist.apache.org/repos/dist/dev/flink/flink-1.15.0-rc2/ >> [3]https://dist.apache.org/repos/dist/release/flink/KEYS >> [4]https://repository.apache.org/content/repositories/orgapacheflink-1495/ >> [5]https://github.com/apache/flink/releases/tag/release-1.15.0-rc2/[6]https://github.com/apache/flink-web/pull/526
