Hi Martijn, Both FLINK-28988 and FLINK-29849 have been picked into 1.16 branch and the 'Release Note' content of the jira has been updated.
Best, Lincoln Lee Zhu Zhu <reed...@gmail.com> 于2022年12月23日周五 10:51写道: > Hi Martjin, > > Thank you for bringing this up! +1 to release 1.16.1. > > There's a critical problem (FLINK-30334) of HybridSource and a fix is in > review. > I hope we can include the fix in 1.16.1. > > Thanks, > Zhu > > yh z <zhengyunhon...@gmail.com> 于2022年12月22日周四 16:11写道: > > > > Hi Martijn, > > > > +1 > > Thank you for bringing this up. There is a serious bug in planner rule > > #FlinkJoinToMultiJoinRule, which will generate a wrong join reorder plan > > and will cause data correctness issue: > > https://issues.apache.org/jira/browse/FLINK-30270 (reviewing) > > > > I hope this bug fix can be picked to 1.16.1 to avoid data correctness > > problems that users cannot perceive. > > > > Glad to hear your suggestions. > > > > Best, > > Yunhong Zheng > > > > Lincoln Lee <lincoln.8...@gmail.com> 于2022年12月21日周三 21:44写道: > > > > > Hi Martijn, > > > > > > Agree that we need to detail the specific case in the release notes. I > will > > > update the 'Release Note' related content of the three issues before > the > > > release. > > > Also update the progress of the last issue FLINK-29849, which has been > > > merged to master. > > > > > > If no one objects, FLINK-28988 and FLINK-29849 need to be tagged with > > > 1.16.1 and picked to the 1.16 branch (I don't have permission to do > this > > > yet, would you like to help with this?) > > > > > > Best, > > > Lincoln Lee > > > > > > > > > Martijn Visser <martijnvis...@apache.org> 于2022年12月21日周三 16:00写道: > > > > > > > Hi Lincoln, > > > > > > > > I'm +1 for also merging them back to 1.16.1. In the release notes we > > > should > > > > make it clear in which situations incompatibility issues will arise, > so > > > > that we inform the users correctly. > > > > > > > > Best regards, > > > > > > > > Martijn > > > > > > > > On Wed, Dec 21, 2022 at 8:41 AM godfrey he <godfre...@gmail.com> > wrote: > > > > > > > > > Hi Martijn, > > > > > > > > > > Thank you for bringing this up. > > > > > > > > > > About Lincoln mentioned 3 commits, +1 to pick them into 1.16.1. > > > > > AFAIK, several users have encountered this kind of data correctness > > > > > problem so far, they are waiting a fix release as soon as possible. > > > > > > > > > > Best, > > > > > Godfrey > > > > > > > > > > ConradJam <jam.gz...@gmail.com> 于2022年12月20日周二 15:08写道: > > > > > > > > > > > Hi Martijn, > > > > > > > > > > > > FLINK-30116 <https://issues.apache.org/jira/browse/FLINK-30116> > > > After > > > > > > merge.Flink Web Ui Configuration Can't show it,I checked the data > > > > > returned > > > > > > by the back end and there is no problem, but there is an error > in the > > > > > front > > > > > > end, as shown in the picture below, can someone take a look > before > > > > > release > > > > > > 1.16.1 ? > > > > > > > > > > > > [image: Pasted Graphic.png] > > > > > > > > > > > > [image: Pasted Graphic 1.png] > > > > > > > > > > > > Martijn Visser <martijnvis...@apache.org> 于2022年12月16日周五 > 02:52写道: > > > > > > > > > > > >> Hi everyone, > > > > > >> > > > > > >> I would like to open a discussion about releasing Flink 1.16.1. > > > We've > > > > > >> released Flink 1.16 at the end of October, but we already have > 58 > > > > fixes > > > > > >> listed for 1.16.1, including a blocker [1] on the environment > > > > variables > > > > > >> and > > > > > >> a number of critical issues. Some of the critical issues are > related > > > > to > > > > > >> the > > > > > >> bugs on the Sink API, on PyFlink and some correctness issues. > > > > > >> > > > > > >> There are also a number of open issues with a fixVersion set to > > > > 1.16.1, > > > > > so > > > > > >> it would be good to understand what the community thinks of > > > starting a > > > > > >> release or if there are some fixes that should be included with > > > > 1.16.1. > > > > > >> > > > > > >> Best regards, > > > > > >> > > > > > >> Martijn > > > > > >> > > > > > >> [1] https://issues.apache.org/jira/browse/FLINK-30116 > > > > > >> > > > > > > > > > > > > > > > > > > >