Hello all, I have been discussing the Python issue with Dian and it appears this issue has a large blast radius. Given we only have 1 binding vote so far I am inclined to cancel this release candidate in favour of an RC2. This will possibly remove the need for a 1.15.5 followup next month.
The vote is closed, I will follow up with an RC2. Thanks, Danny On Mon, Mar 6, 2023 at 2:46 AM Dian Fu <dian0511...@gmail.com> wrote: > Hi Danny, > > It impacts all jobs using new sinks in Python DataStream API and has > nothing to do with the tumbling window. > > I just want to ensure that it will finally be included in a patch release > of 1.15.x. As it mentioned `Given that Flink 1.17 is on the horizon, it > will be good to release critical bug fixes before 1.15 goes out of support` > in the discussion thread of 1.15.4, I have thought that this will be the > last release of 1.15.x. If there will be 1.15.5, I'm fine to include it in > 1.15.5. Thanks for your clarify. > > Regards, > Dian > > > > > > > On Sat, Mar 4, 2023 at 12:07 AM Danny Cranmer <dannycran...@apache.org> > wrote: > > > Hello Dian, > > > > As per the new version support strategy [1], we will perform a Flink > 1.15.5 > > patch if there are any resolved critical/blocker issues at the point in > > which 1.17.0 is released. The issue referenced is a Major. I am not > > inclined to cancel the release candidate at this point unless I get a -1 > > veto. Is this issue impacting all Python Datastream apps with a Tumbling > > window or a subset? I am wondering why it is only a Major? > > > > Thanks, > > Danny > > > > [1] https://lists.apache.org/thread/9w99mgx3nw5tc0v26wcvlyqxrcrkpzdz > > > > On Fri, Mar 3, 2023 at 2:09 AM Dian Fu <dian0511...@gmail.com> wrote: > > > > > Hi Danny, > > > > > > I'm sorry that I'm coming to this thread a little late. It seems that > > this > > > will be the last bugfix release of Flink 1.15? If so, I'd like to also > > > include https://issues.apache.org/jira/browse/FLINK-31272 into this > > > release > > > which fixes a serious issue of PyFlink. > > > > > > Regards, > > > Dian > > > > > > > > > > > > On Thu, Mar 2, 2023 at 5:51 PM Yu Li <car...@gmail.com> wrote: > > > > > > > +1 (binding) > > > > > > > > > > > > - Checked the diff between 1.15.3 and 1.15.4-rc1: *OK* ( > > > > > > > > > > https://github.com/apache/flink/compare/release-1.15.3...release-1.15.4-rc1 > > > > ) > > > > > > > > - AWS SDKv2 version has been bumped to 2.19.14 through FLINK-30633 > > and > > > > all NOTICE files updated correctly > > > > > > > > - Checked release notes: *OK* > > > > > > > > - Checked sums and signatures: *OK* > > > > > > > > - Maven clean install from source: *OK* (8u181) > > > > > > > > - Checked the jars in the staging repo: *OK* > > > > > > > > - Checked the website updates: *OK* > > > > > > > > > > > > Thanks for driving this release, Danny! > > > > > > > > > > > > Best Regards, > > > > Yu > > > > > > > > > > > > On Wed, 1 Mar 2023 at 02:01, Ahmed Hamdy <hamdy10...@gmail.com> > wrote: > > > > > > > > > Thanks Danny, > > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified hashes and signatures > > > > > - Built Source archive using maven > > > > > - Web PR looks good. > > > > > - Started WordCount Example > > > > > > > > > > On Tue, 28 Feb 2023 at 16:37, Jing Ge <j...@ververica.com.invalid> > > > > wrote: > > > > > > > > > > > Thanks Danny, > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > - GPG signatures looks good > > > > > > - checked dist and maven repo > > > > > > - maven clean install from source > > > > > > - checked version consistency in pom files > > > > > > - went through the web release notes and found one task is still > > > open: > > > > > > FLINK-31133 [1] > > > > > > - download artifacts > > > > > > - started/stopped local cluster and ran WordCount job in > streaming > > > and > > > > > > batch > > > > > > > > > > > > Best regards, > > > > > > Jing > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-31133 > > > > > > > > > > > > On Tue, Feb 28, 2023 at 3:12 PM Matthias Pohl > > > > > > <matthias.p...@aiven.io.invalid> wrote: > > > > > > > > > > > > > Thanks Danny. > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > * Downloaded artifacts > > > > > > > * Built Flink from sources > > > > > > > * Verified SHA512 checksums GPG signatures > > > > > > > * Compared checkout with provided sources > > > > > > > * Verified pom file versions > > > > > > > * Went over NOTICE file/pom files changes without finding > > anything > > > > > > > suspicious > > > > > > > * Deployed standalone session cluster and ran WordCount example > > in > > > > > batch > > > > > > > and streaming: Nothing suspicious in log files found > > > > > > > > > > > > > > On Tue, Feb 28, 2023 at 9:50 AM Teoh, Hong > > > > > <lian...@amazon.co.uk.invalid > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Thanks Danny for driving this > > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > * Hashes and Signatures look good > > > > > > > > * All required files on dist.apache.org > > > > > > > > * Source archive builds using maven > > > > > > > > * Started packaged example WordCountSQLExample job > > > > > > > > * Web PR looks good. > > > > > > > > > > > > > > > > Cheers, > > > > > > > > Hong > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 24 Feb 2023, at 05:36, Weihua Hu < > huweihua....@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > > > > > CAUTION: This email originated from outside of the > > > organization. > > > > Do > > > > > > not > > > > > > > > click links or open attachments unless you can confirm the > > sender > > > > and > > > > > > > know > > > > > > > > the content is safe. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks Danny. > > > > > > > > > > > > > > > > > > +1(non-binding) > > > > > > > > > > > > > > > > > > Tested the following: > > > > > > > > > - Download the artifacts and build image > > > > > > > > > - Ran WordCount on Kubernetes(session mode and application > > > mode) > > > > > > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > Weihua > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Feb 24, 2023 at 12:29 PM Yanfei Lei < > > > fredia...@gmail.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > >> Thanks Danny. > > > > > > > > >> +1 (non-binding) > > > > > > > > >> > > > > > > > > >> - Downloaded artifacts & built Flink from sources > > > > > > > > >> - Verified GPG signatures of bin and source. > > > > > > > > >> - Verified version in poms > > > > > > > > >> - Ran WordCount example in streaming and batch > > mode(standalone > > > > > > > cluster) > > > > > > > > >> - Went over flink-web PR, looks good except for Sergey's > > > remark. > > > > > > > > >> > > > > > > > > >> Danny Cranmer <dannycran...@apache.org> 于2023年2月24日周五 > > > 02:08写道： > > > > > > > > >>> > > > > > > > > >>> Hi everyone, > > > > > > > > >>> Please review and vote on the release candidate #1 for > the > > > > > version > > > > > > > > >> 1.15.4, > > > > > > > > >>> as follows: > > > > > > > > >>> [ ] +1, Approve the release > > > > > > > > >>> [ ] -1, Do not approve the release (please provide > specific > > > > > > comments) > > > > > > > > >>> > > > > > > > > >>> > > > > > > > > >>> The complete staging area is available for your review, > > which > > > > > > > includes: > > > > > > > > >>> * JIRA release notes [1], > > > > > > > > >>> * the official Apache source release and binary > convenience > > > > > > releases > > > > > > > to > > > > > > > > >> be > > > > > > > > >>> deployed to dist.apache.org [2], which are signed with > the > > > key > > > > > > with > > > > > > > > >>> fingerprint 125FD8DB [3], > > > > > > > > >>> * all artifacts to be deployed to the Maven Central > > > Repository > > > > > [4], > > > > > > > > >>> * source code tag "release-1.15.4-rc1" [5], > > > > > > > > >>> * website pull request listing the new release and adding > > > > > > > announcement > > > > > > > > >> blog > > > > > > > > >>> post [6]. > > > > > > > > >>> > > > > > > > > >>> The vote will be open for at least 72 hours (excluding > > > weekends > > > > > > > > >> 2023-02-28 > > > > > > > > >>> 19:00). It is adopted by majority approval, with at > least 3 > > > PMC > > > > > > > > >> affirmative > > > > > > > > >>> votes. > > > > > > > > >>> > > > > > > > > >>> Thanks, > > > > > > > > >>> Danny > > > > > > > > >>> > > > > > > > > >>> [1] > > > > > > > > >>> > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352526 > > > > > > > > >>> [2] > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.15.4-rc1/ > > > > > > > > >>> [3] > https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > >>> [4] > > > > > > > > >>> > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1588/org/apache/flink/ > > > > > > > > >>> [5] > > > > > > https://github.com/apache/flink/releases/tag/release-1.15.4-rc1 > > > > > > > > >>> [6] https://github.com/apache/flink-web/pull/611 > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> -- > > > > > > > > >> Best, > > > > > > > > >> Yanfei > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
