Hi Martijn, Since this RC vote was opened, we had three critical bug fixes that was merged for the Kafka connector:
- https://issues.apache.org/jira/browse/FLINK-31363 - https://issues.apache.org/jira/browse/FLINK-31305 - https://issues.apache.org/jira/browse/FLINK-31620 Given the severity of these issues (all of them are violations of exactly-once semantics), and the fact that they are currently not included yet in any released version, do you think it makes sense to cancel this RC in favor of a new one that includes these? Since this RC vote has been stale for quite some time already, it doesn't seem like we're throwing away too much effort that has already been done if we start a new RC with these critical fixes included. What do you think? Thanks, Gordon On Thu, Feb 9, 2023 at 3:26 PM Tzu-Li (Gordon) Tai <tzuli...@apache.org> wrote: > +1 (binding) > > - Verified legals (license headers and root LICENSE / NOTICE file). AFAICT > no dependencies require explicit acknowledgement in the NOTICE files. > - No binaries in staging area > - Built source with tests > - Verified signatures and hashes > - Web PR changes LGTM > > Thanks Martijn! > > Cheers, > Gordon > > On Mon, Feb 6, 2023 at 6:12 PM Mason Chen <mas.chen6...@gmail.com> wrote: > >> That makes sense, thanks for the clarification! >> >> Best, >> Mason >> >> On Wed, Feb 1, 2023 at 7:16 AM Martijn Visser <martijnvis...@apache.org> >> wrote: >> >> > Hi Mason, >> > >> > Thanks, [4] is indeed a copy-paste error and you've made the right >> > assumption that >> > >> > >> https://repository.apache.org/content/repositories/orgapacheflink-1582/org/apache/flink/ >> > is the correct maven central link. >> > >> > I think we should use FLINK-30052 to move the Kafka connector code from >> the >> > 1.17 release also over the Kafka connector repo (especially since >> there's >> > now a v3.0 branch for the Kafka connector, so it can be merged in main). >> > When those commits have been merged, we can make a next Kafka connector >> > release (which is equivalent to the 1.17 release, which can only be done >> > when 1.17 is done because of the split level watermark alignment) and >> then >> > FLINK-30859 can be finished. >> > >> > Best regards, >> > >> > Martijn >> > >> > Op wo 1 feb. 2023 om 09:16 schreef Mason Chen <mas.chen6...@gmail.com>: >> > >> > > +1 (non-binding) >> > > >> > > * Verified hashes and signatures >> > > * Verified no binaries >> > > * Verified LICENSE and NOTICE files >> > > * Verified poms point to 3.0.0-1.16 >> > > * Reviewed web PR >> > > * Built from source >> > > * Verified git tag >> > > >> > > I think [4] your is a copy-paste error and I did all the verification >> > > assuming that >> > > >> > > >> > >> https://repository.apache.org/content/repositories/orgapacheflink-1582/org/apache/flink/ >> > > is the correct maven central link. >> > > >> > > Regarding the release notes, should we close >> > > https://issues.apache.org/jira/browse/FLINK-30052 and link it there? >> > I've >> > > created https://issues.apache.org/jira/browse/FLINK-30859 to remove >> the >> > > existing code from the master branch. >> > > >> > > Best, >> > > Mason >> > > >> > > On Tue, Jan 31, 2023 at 6:23 AM Martijn Visser < >> martijnvis...@apache.org >> > > >> > > wrote: >> > > >> > > > Hi everyone, >> > > > Please review and vote on the release candidate #1 for >> > > > flink-connector-kafka version 3.0.0, as follows: >> > > > [ ] +1, Approve the release >> > > > [ ] -1, Do not approve the release (please provide specific >> comments) >> > > > >> > > > Note: this is the same code as the Kafka connector for the Flink >> 1.16 >> > > > release. >> > > > >> > > > The complete staging area is available for your review, which >> includes: >> > > > * JIRA release notes [1], >> > > > * the official Apache source release to be deployed to >> dist.apache.org >> > > > [2], >> > > > which are signed with the key with fingerprint >> > > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], >> > > > * all artifacts to be deployed to the Maven Central Repository [4], >> > > > * source code tag v3.0.0-rc1 [5], >> > > > * website pull request listing the new release [6]. >> > > > >> > > > The vote will be open for at least 72 hours. It is adopted by >> majority >> > > > approval, with at least 3 PMC affirmative votes. >> > > > >> > > > Thanks, >> > > > Release Manager >> > > > >> > > > [1] >> > > > >> > > > >> > > >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352577 >> > > > [2] >> > > > >> > > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.0-rc1 >> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS >> > > > [4] >> > > > >> > > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.0-rc1/ >> > > > [5] >> > > > >> > https://github.com/apache/flink-connector-kafka/releases/tag/v3.0.0-rc1 >> > > > [6] https://github.com/apache/flink-web/pull/606 >> > > > >> > > >> > >> >
