-1 (binding) as the blocker issue FLINK-31927[1] found - Reviewed the PR [2] and left one comment that the linked issue is incorrect.
Best, Leonard [1] https://issues.apache.org/jira/browse/FLINK-31927 [2] https://github.com/apache/flink-connector-cassandra/pull/13 > 2023年5月3日 下午5:26，Etienne Chauchot <echauc...@apache.org> 写道： > > Hi all, > > @Danny, I just submitted the fix PR to unblock the release: > https://github.com/apache/flink-connector-cassandra/pull/13 > > Best > > Etienne > > Le 02/05/2023 à 14:52, Danny Cranmer a écrit : >> Thanks for reporting this issue Etienne. Why was it not detected by the >> unit/integration tests? Can we cover this on the CI? >> >> This VOTE is closed, I will open RC2 once the issue has been resolved. In >> the meantime we could consider reopening 3.0.1 [1] for Flink 1.17 support. >> I will reopen if there is a demand for it. >> >> Thanks, >> Danny >> >> >> [1] https://lists.apache.org/thread/30c3yhd561o57x0prt7jqt055r4xd6lf >> >> On Mon, Apr 24, 2023 at 7:28 PM Etienne Chauchot <echauc...@apache.org> >> wrote: >> >>> Hi, >>> >>> Thanks Danny for driving this new release. It now contains the new >>> source, thanks. >>> >>> I'm off but I wanted to test this release still. I made a very quick job >>> (1) to read from a Cassandra cluster with the new source. >>> >>> I found an issue: the source raises a j"ava.lang.NoClassDefFoundError: >>> com/codahale/metrics/Gauge" when trying to connect to the cluster on >>> Flink 1.16.0. >>> >>> As I'm on vacation right now, I don't have time to solve this now but >>> I'll do within a week. >>> >>> vote: -1 (non-binding) >>> >>> here is the blocker ticket: >>> https://issues.apache.org/jira/browse/FLINK-31927 >>> >>> [1] >>> >>> https://github.com/echauchot/flink-samples/blob/edf4ad1624b2ad02af380efa6b5caa26bb7a274a/src/main/java/org/example/CassandraPojoSource.java >>> >>> Best >>> >>> Etienne >>> >>> Le 19/04/2023 à 21:07, Martijn Visser a écrit : >>>> +1 (binding) >>>> >>>> - Validated hashes >>>> - Verified signature >>>> - Verified that no binaries exist in the source archive >>>> - Build the source with Maven >>>> - Verified licenses >>>> - Verified web PRs >>>> >>>> On Fri, Apr 14, 2023 at 2:42 PM Elphas Toringepi <elphast...@gmail.com> >>>> wrote: >>>> >>>>> Thanks Danny >>>>> >>>>> +1 (non-binding) >>>>> >>>>> * Checked release notes >>>>> * Validated signature and checksum >>>>> * Apache source builds with JDK 11 >>>>> * Approved website PR >>>>> >>>>> Kind regards, >>>>> Elphas >>>>> >>>>> >>>>> On Fri, Apr 14, 2023 at 1:14 PM Danny Cranmer <dannycran...@apache.org> >>>>> wrote: >>>>> >>>>>> Hi everyone, >>>>>> Please review and vote on the release candidate #1 for the version >>> 3.1.0, >>>>>> as follows: >>>>>> [ ] +1, Approve the release >>>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>>> >>>>>> This version supports both Flink 1.16.x and Flink 1.17.x >>>>>> >>>>>> The complete staging area is available for your review, which includes: >>>>>> * JIRA release notes [1], >>>>>> * the official Apache source release to be deployed to dist.apache.org >>>>>> [2], >>>>>> which are signed with the key with fingerprint >>>>>> 0F79F2AFB2351BC29678544591F9C1EC125FD8DB [3], >>>>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>>>> * source code tag v3.1.0-rc1 [5], >>>>>> * website pull request listing the new release [6]. >>>>>> >>>>>> The vote will be open for at least 72 hours. It is adopted by majority >>>>>> approval, with at least 3 PMC affirmative votes. >>>>>> >>>>>> Thanks, >>>>>> Danny >>>>>> >>>>>> [1] >>>>>> >>>>>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353030 >>>>>> [2] >>>>>> >>>>>> >>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-cassandra-3.1.0-rc1/ >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>>>> [4] >>>>> https://repository.apache.org/content/repositories/orgapacheflink-1627 >>>>>> [5] >>>>>> >>> https://github.com/apache/flink-connector-cassandra/releases/tag/v3.1.0-rc1 >>>>>> [6] https://github.com/apache/flink-web/pull/642 >>>>>>
