Thank you Danny! :) On Tue, May 9, 2023 at 11:22 AM Danny Cranmer <dannycran...@apache.org> wrote:
> Hey Martijn, I think you were missing 1 binding vote, so I have reviewed it > in hindsight. > > +1 (binding) > > - Release notes look good > - Verified signature and hashes of released source [1] > - Verified there are no binaries in the source archive > - Tag is present in Github > - Built from source, tests pass > > [1] > > https://dist.apache.org/repos/dist/release/flink/flink-connector-rabbitmq-3.0.1/ > > Thanks, > Danny > > On Mon, May 8, 2023 at 1:05 PM Martijn Visser <martijnvis...@apache.org> > wrote: > > > Thanks all. This vote is now closed, I'll announce the results in a > > separate thread. > > > > On Sat, May 6, 2023 at 4:45 PM Jing Ge <j...@ververica.com.invalid> > wrote: > > > > > +1 > > > > > > - built the source > > > - verified signature > > > - verified hash > > > - contains no compiled binaries > > > - checked tag > > > - web PR looks good > > > > > > Best regards, > > > Jing > > > > > > > > > On Fri, May 5, 2023 at 9:14 AM Khanh Vu <vtkhan...@gmail.com> wrote: > > > > > > > Sorry, the above report is supposed for > > flink-connector-gpc-pubsub-3.0.1 > > > > > > > > ----------------- > > > > Here is the check for this one: > > > > > > > > +1 (non-binding) > > > > > > > > - Verified sha512 checksum matches file archive. > > > > - Verified file archive is signed and signature is authenticated. > > > > - Verified no binaries exist in the source archive. > > > > - Verified source archive is consistent with Github source code with > > tag > > > > v3.0.1-rc1, at commit 9827e71662c8f155cda5efe5ebbac804fd0fd8e2 > > > > - Source built successfully with maven. > > > > - (No end to end tests run for this connector) > > > > > > > > Best regards, > > > > Khanh Vu > > > > > > > > > > > > On Fri, May 5, 2023 at 7:55 AM Khanh Vu <vtkhan...@gmail.com> wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified sha512 checksum matches file archive. > > > > > - Verified file archive is signed and signature is authorized. > > > > > - Verified no binaries exist in the source archive. > > > > > - Verified source archive is consistent with Github source code > with > > > > > tag v3.0.1-rc1, at commit 73e56edb2aa4513f6a73dc071545fb2508fd2d44 > > > > > - Source built successfully with maven. > > > > > - Executed end to end tests successfully for flink versions: > 1.15.4, > > > > > 1.16.1, 1.17.0 > > > > > > > > > > Best regards, > > > > > Khanh Vu > > > > > > > > > > > > > > > On Thu, May 4, 2023 at 3:47 AM Leonard Xu <xbjt...@gmail.com> > wrote: > > > > > > > > > >> > > > > >> +1 (binding) > > > > >> > > > > >> - built from source code succeeded > > > > >> - verified signatures > > > > >> - verified hashsums > > > > >> - checked Github release tag > > > > >> - reviewed the web PR > > > > >> > > > > >> Best, > > > > >> Leonard > > > > >> > > > > >> > > > > >> 2023年4月20日 上午3:29，Martijn Visser <martijnvis...@apache.org> 写道： > > > > >> > > > > >> +1 (binding) > > > > >> > > > > >> - Validated hashes > > > > >> - Verified signature > > > > >> - Verified that no binaries exist in the source archive > > > > >> - Build the source with Maven > > > > >> - Verified licenses > > > > >> - Verified web PRs > > > > >> > > > > >> On Mon, Apr 17, 2023 at 7:00 PM Ryan Skraba > > > > <ryan.skr...@aiven.io.invalid > > > > >> > > > > > >> wrote: > > > > >> > > > > >> Hello! +1 (non-binding) > > > > >> > > > > >> I've validated the source for the RC1: > > > > >> flink-connector-rabbitmq-3.0.1-src.tgz > > > > >> * The sha512 checksum is OK. > > > > >> * The source file is signed correctly. > > > > >> * The signature A5F3BCE4CBE993573EC5966A65321B8382B219AF is found > in > > > the > > > > >> KEYS file, and on https://keys.openpgp.org > > > > >> * The source file is consistent with the Github tag v3.0.1-rc1, > > which > > > > >> corresponds to commit 9827e71662c8f155cda5efe5ebbac804fd0fd8e2 > > > > >> - The files explicitly excluded by create_pristine_sources (such > > as > > > > >> .gitignore and the submodule tools/releasing/shared) are not > > present. > > > > >> * Has a LICENSE file and a NOTICE file. The sql-connector has a > > > > >> NOTICE file for bundled artifacts. > > > > >> * Does not contain any compiled binaries. > > > > >> > > > > >> * The sources can be compiled and tests pass with flink.version > > 1.17.0 > > > > and > > > > >> flink.version 1.16.1 > > > > >> > > > > >> * Nexus has three staged artifact ids for 3.0.1-1.16 and > 3.0.1-1.17 > > > > >> - flink-connector-rabbitmq-parent (only .pom) > > > > >> - flink-connector-rabbitmq (.jar, -sources.jar, -javadoc.jar and > > .pom) > > > > >> - flink-sql-connector-rabbitmq (.jar, -sources.jar and .pom) > > > > >> * All 16 files have been signed with the same key as above, and > have > > > > >> correct sha1 and md5 checksums. > > > > >> > > > > >> I didn't run any additional smoke tests other than the integration > > > test > > > > >> cases. > > > > >> > > > > >> A couple minor points, but nothing that would block this release. > > > > >> > > > > >> - like flink-connector-gcp-pubsub-parent, the > > > > >> flink-connector-rabbitmq-parent:3.0.1-1.17 pom artifact has the > > > > >> flink.version set to 1.16.0, which might be confusing. > > > > >> - the NOTICE file for sql-connector has the wrong year. > > > > >> > > > > >> All my best and thanks for the release. > > > > >> > > > > >> Ryan > > > > >> > > > > >> > > > > >> On Thu, Apr 13, 2023 at 4:45 PM Martijn Visser < > > > > martijnvis...@apache.org> > > > > >> wrote: > > > > >> > > > > >> Hi everyone, > > > > >> Please review and vote on the release candidate #1 for the version > > > > 3.0.1, > > > > >> as follows: > > > > >> [ ] +1, Approve the release > > > > >> [ ] -1, Do not approve the release (please provide specific > > comments) > > > > >> > > > > >> This version is compatible with Flink 1.16.x and Flink 1.17.x > > > > >> > > > > >> The complete staging area is available for your review, which > > > includes: > > > > >> * JIRA release notes [1], > > > > >> * the official Apache source release to be deployed to > > > dist.apache.org > > > > >> [2], > > > > >> which are signed with the key with fingerprint > > > > >> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > > > > >> * all artifacts to be deployed to the Maven Central Repository > [4], > > > > >> * source code tag v3.0.1-rc1 [5], > > > > >> * website pull request listing the new release [6]. > > > > >> > > > > >> The vote will be open for at least 72 hours. It is adopted by > > majority > > > > >> approval, with at least 3 PMC affirmative votes. > > > > >> > > > > >> Thanks, > > > > >> Release Manager > > > > >> > > > > >> [1] > > > > >> > > > > >> > > > > >> > > > > >> > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352699 > > > > >> > > > > >> [2] > > > > >> > > > > >> > > > > >> > > > > >> > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-rabbitmq-3.0.1-rc1 > > > > >> > > > > >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > >> [4] > > > > >> > > > > https://repository.apache.org/content/repositories/orgapacheflink-1615/ > > > > >> [5] > > > > >> > > > > >> > > > > > > > > > > https://github.com/apache/flink-connector-rabbitmq/releases/tag/v3.0.1-rc1 > > > > >> > > > > >> [6] https://github.com/apache/flink-web/pull/639 > > > > >> > > > > >> > > > > >> > > > > >> > > > > > > > > > >
