Hi all, > For example, a user might want to read in logs, perform some aggregations and publish it into a metrics store for visualisation. This might be a great use-case for reducing the cardinality of metrics!
I can see that. What I would like to see in the FLIP is a proposal on the boundaries of the metrics reporter vs the Prometheus sink. I think it's important that we make clear when to use a metric reporter and when not. I can imagine that there will be Flink users who think that they can get data from the metric reporter, make aggregrations in Flink and then store it using the Prometheus sink. Overall, I think more context must be added to the FLIP, especially on the motivation. Best regards, Martijn On Fri, May 19, 2023 at 4:28 PM Karthi Thyagarajan <kar...@karthitect.com> wrote: > Hi Lijie > > Thank you for pointing this out. I've corrected it [1]. Also, this page > [2] still shows 178 and 229 as available, which is why I picked it up. > > Thanks > Karthi > > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-312%3A+Prometheus+Sink+Connector > [2] > https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals > > On May 15, 2023, at 9:37 PM, Lijie Wang <wangdachui9...@gmail.com> wrote: > > > Hi Karthi, > > I think you are using a wrong FLIP id, the FLIP-229 has already be used[1]. > > [1] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-229%3A+Introduces+Join+Hint+for+Flink+SQL+Batch+Job > > Best, > Lijie > > Martijn Visser <martijnvis...@apache.org> 于2023年5月16日周二 04:44写道： > > Hi Karthi, > > Thanks for the FLIP and opening up the discussion. My main question is: why > should we create a separate connector and not use and/or improve the > existing integrations with Prometheus? I would like to understand more so > that it can be added to the motivation of the FLIP. > > Best regards, > > Martijn > > On Mon, May 15, 2023 at 6:03 PM Karthi Thyagarajan <kar...@karthitect.com> > wrote: > > > Hello all, > > > > We would like to start a discussion thread on FLIP-229: Prometheus Sink > > Connector [1] where we propose to provide a sink connector for Prometheus > > [2] based on the Async Sink [3]. Looking forward to comments and > feedback. > > Thank you. > > > > [1] > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-229%3A+Prometheus+Sink+Connector > > [2] https://prometheus.io/ > > [3] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-171%3A+Async+Sink > > > > >
