Hi Galen, Thanks for the hint which is helpful for us to have a clear big picture. Afaiac, this will not be a blocking issue for the graduation. There will always be some (potential) bugs in the implementation. The API is very stable from 2020. The timing is good to graduate. WDYT? Furthermore, I'd like to have more opinions. All opinions together will help the community build a mature API graduation process.
Best regards, Jing On Tue, Jun 20, 2023 at 12:48 PM Galen Warren <ga...@cvillewarrens.com.invalid> wrote: > Is this issue still unresolved? > > https://issues.apache.org/jira/plugins/servlet/mobile#issue/FLINK-30238 > > Based on prior discussion, I believe this could lead to data loss with > FileSink. > > > > On Tue, Jun 20, 2023, 5:41 AM Jing Ge <j...@ververica.com.invalid> wrote: > > > Hi all, > > > > The FileSink has been marked as @Experimental[1] since Oct. 2020. > > According to FLIP-197[2], I would like to propose to graduate it > > to @PublicEvloving in the upcoming 1.18 release. > > > > On the other hand, as a related topic, FileSource was marked > > as @PublicEvolving[3] 3 years ago. It deserves a graduation discussion > too. > > To keep this discussion lean and efficient, let's focus on FlieSink in > this > > thread. There will be another discussion thread for the FileSource. > > > > I was wondering if anyone might have any concerns. Looking forward to > > hearing from you. > > > > > > Best regards, > > Jing > > > > > > > > > > > > > > [1] > > > > > https://github.com/apache/flink/blob/4006de973525c5284e9bc8fa6196ab7624189261/flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/FileSink.java#L129 > > [2] > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-197%3A+API+stability+graduation+process > > [3] > > > > > https://github.com/apache/flink/blob/4006de973525c5284e9bc8fa6196ab7624189261/flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/FileSource.java#L95 > > >
