Hi Matthias, Thanks for raising this up! I saw your conversation with Chesnay in the PR and after reading the historical discussions, there should be no doubt to deprecate Time classes. +1
I just have a related question: Do we need to create a FLIP each time when we want to deprecate any classes? (BTW, FLIP-335 contains useful information. It makes sense to write it) Best regards, Jing On Thu, Jul 13, 2023 at 12:09 PM Matthias Pohl <matthias.p...@aiven.io.invalid> wrote: > The 2.0 feature list includes the removal of Flink's Time classes in favor > of the JDKs java.time.Duration class. There was already a discussion about > it in [1] and FLINK-14068 [2] was created as a consequence of this > discussion. > > I started working on marking the APIs as deprecated in FLINK-32570 [3] > where Chesnay raised a fair point that there isn't a FLIP, yet, to > formalize this public API change. Therefore, I went ahead and created > FLIP-335 [4] to have this change properly documented. > > I'm not 100% sure whether there are better ways of checking whether we're > covering everything Public API-related. There are even classes which I > think might be user-facing but are not labeled accordingly (e.g. > flink-cep). But I don't have the proper knowledge in these parts of the > code. Therefore, I would propose marking these methods as deprecated, > anyway, to be on the safe side. > > I'm open to any suggestions on improving the Test Plan of this change. > > I'm looking forward to feedback on this FLIP. > > Best, > Matthias > > [1] https://lists.apache.org/thread/76yywnwf3lk8qn4dby0vz7yoqx7f7pkj > [2] https://issues.apache.org/jira/browse/FLINK-14068 > [3] https://issues.apache.org/jira/browse/FLINK-32570 > [4] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-335%3A+Removing+Flink%27s+Time+classes >
